You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by robertamarton <gi...@git.apache.org> on 2015/09/11 17:10:32 UTC

[GitHub] incubator-trafodion pull request: [TRAFODION-1488] Master exec log...

GitHub user robertamarton opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/79

    [TRAFODION-1488] Master exec log files missing timestamps

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertamarton/incubator-trafodion fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #79
    
----
commit 324ab95e3ea11492b42b695feea79e1c73faf7b4
Author: Roberta Marton <ro...@esgyn.com>
Date:   2015-09-11T15:05:29Z

    JIRA TRAFODION-1488
    
    Fixed several issues related to logging:
    
    log4cxx.trafodion.masterexe.config changes:
    - The timestamp was not being reported in the log4cxx files
    - Messages were being displayed twice
    - Turned on debug logging for privilege manager events
    
    SQL logging mechanism:
    - Messages were not being displayed when expected
    
    Regression test logging:
     - changed TEST009 to log hive requests to a rundir log. This test is
       failing during daily runs and this change will help isolate the issue.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1488] Master exec log...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafodion/pull/79


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1488] Master exec log...

Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/79#discussion_r39287259
  
    --- Diff: core/sql/qmscommon/QRLogger.cpp ---
    @@ -609,7 +623,13 @@ void QRLogger::log(std::string &cat,
         {
             if ( myLevel == log4cxx::Level::getOff() )
               return;
    -        if ( myLevel->toInt() < paramLevel->toInt() )
    +
    +        int_32 configuredLevel = myLevel->toInt();
    +        int_32 requestedLevel = paramLevel->toInt();
    +  
    +        // If the configured logging level is greater (more restrictive) than
    +        // the requested level, don't log. 
    +        if ( configuredLevel > requestedLevel)
    --- End diff --
    
    Thanks for these changes. The code is easier to understand now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---