You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/13 10:09:53 UTC
[GitHub] [airflow] blcksrx opened a new pull request #7150: [AIRFLOW-6547]
remove unnecessary bunch of codes on pinot hook
blcksrx opened a new pull request #7150: [AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
URL: https://github.com/apache/airflow/pull/7150
---
Pinot hook has been implemented by pinotdb and it uses sqlalchmey to interact with pinot. so in this hook the get_records and get_first methods are unnecessary
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7150:
[AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7150: [AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
URL: https://github.com/apache/airflow/pull/7150#issuecomment-573638436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=h1) Report
> Merging [#7150](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7150 +/- ##
==========================================
- Coverage 85.28% 84.99% -0.29%
==========================================
Files 707 707
Lines 39255 39247 -8
==========================================
- Hits 33478 33359 -119
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/apache/pinot/hooks/pinot.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3Bpbm90L2hvb2tzL3Bpbm90LnB5) | `91.05% <ø> (-0.55%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=footer). Last update [ab80880...a733ac1](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] stale[bot] closed pull request #7150: [AIRFLOW-6547]
remove unnecessary bunch of codes on pinot hook
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #7150: [AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
URL: https://github.com/apache/airflow/pull/7150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] stale[bot] commented on issue #7150: [AIRFLOW-6547]
remove unnecessary bunch of codes on pinot hook
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #7150: [AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
URL: https://github.com/apache/airflow/pull/7150#issuecomment-592881027
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7150:
[AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7150: [AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
URL: https://github.com/apache/airflow/pull/7150#issuecomment-573638436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=h1) Report
> Merging [#7150](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7150 +/- ##
==========================================
- Coverage 85.28% 84.99% -0.29%
==========================================
Files 707 707
Lines 39255 39247 -8
==========================================
- Hits 33478 33359 -119
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/apache/pinot/hooks/pinot.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3Bpbm90L2hvb2tzL3Bpbm90LnB5) | `91.05% <ø> (-0.55%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=footer). Last update [ab80880...a733ac1](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7150: [AIRFLOW-6547] remove
unnecessary bunch of codes on pinot hook
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7150: [AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
URL: https://github.com/apache/airflow/pull/7150#issuecomment-573625732
These methods are required by the DBApiHook class. I'm afraid it won't work properly without it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] blcksrx commented on issue #7150: [AIRFLOW-6547] remove
unnecessary bunch of codes on pinot hook
Posted by GitBox <gi...@apache.org>.
blcksrx commented on issue #7150: [AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
URL: https://github.com/apache/airflow/pull/7150#issuecomment-573643747
> These methods are required by the DBApiHook class. I'm afraid without overwriting the method it won't work properly.
Actually **pinotdb** implemented **sqlalchemy** on itself and it's not necessary to implement these methods separately. Also, the implementation of these methods are like their parents class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #7150: [AIRFLOW-6547]
remove unnecessary bunch of codes on pinot hook
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #7150: [AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
URL: https://github.com/apache/airflow/pull/7150#issuecomment-573625732
These methods are required by the DBApiHook class. I'm afraid without overwriting the method it won't work properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7150: [AIRFLOW-6547]
remove unnecessary bunch of codes on pinot hook
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7150: [AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
URL: https://github.com/apache/airflow/pull/7150#issuecomment-573638436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=h1) Report
> Merging [#7150](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7150 +/- ##
==========================================
- Coverage 85.28% 84.99% -0.29%
==========================================
Files 707 707
Lines 39255 39247 -8
==========================================
- Hits 33478 33359 -119
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/apache/pinot/hooks/pinot.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3Bpbm90L2hvb2tzL3Bpbm90LnB5) | `91.05% <ø> (-0.55%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7150/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=footer). Last update [ab80880...a733ac1](https://codecov.io/gh/apache/airflow/pull/7150?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services