You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/01 07:53:39 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request, #15847: [improve][broker] Make some methods of `ClusterBase` pure async.
mattisonchao opened a new pull request, #15847:
URL: https://github.com/apache/pulsar/pull/15847
### Motivation
See PIP #14365 and change tracker #15043.
### Modifications
- Make `ClusterBase` `deleteFailureDomain` / `getDomain` to pure async.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
`AdminTest#clusters` already cover this change.
### Documentation
- [x] `no-need-doc`
(Please explain why)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #15847: [improve][broker] Make some methods of `ClusterBase` pure async.
Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #15847: [improve][broker] Make some methods of `ClusterBase` pure async.
URL: https://github.com/apache/pulsar/pull/15847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao merged pull request #15847: [improve][broker] Make some methods of `ClusterBase` pure async.
Posted by GitBox <gi...@apache.org>.
mattisonchao merged PR #15847:
URL: https://github.com/apache/pulsar/pull/15847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15847: [improve][broker] Make some methods of `ClusterBase` pure async.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15847:
URL: https://github.com/apache/pulsar/pull/15847#issuecomment-1141516314
@mattisonchao:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org