You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/03/01 19:14:07 UTC
[GitHub] [arrow-adbc] lidavidm opened a new pull request, #483: ci: pin red-arrow for now
lidavidm opened a new pull request, #483:
URL: https://github.com/apache/arrow-adbc/pull/483
Fixes #481.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] kou commented on a diff in pull request #483: ci: pin red-arrow for now
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #483:
URL: https://github.com/apache/arrow-adbc/pull/483#discussion_r1122489054
##########
ci/linux-packages/apt/debian-bookworm/Dockerfile:
##########
@@ -58,6 +58,6 @@ RUN \
python3-pip \
tzdata \
valac && \
- pip3 install --upgrade meson && \
+ pip3 install --break-system-packages --upgrade meson && \
Review Comment:
We can use system Meson: https://github.com/apache/arrow/commit/41aedfdd4e452d547773dd2ea8a493139b24c572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] kou commented on a diff in pull request #483: ci: pin red-arrow for now
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #483:
URL: https://github.com/apache/arrow-adbc/pull/483#discussion_r1122639196
##########
ruby/red-adbc.gemspec:
##########
@@ -52,7 +52,7 @@ Gem::Specification.new do |spec|
spec.files += Dir.glob("lib/**/*.rb")
spec.extensions = ["dependency-check/Rakefile"]
- spec.add_runtime_dependency("red-arrow")
+ spec.add_runtime_dependency("red-arrow", "<11.0.0")
Review Comment:
Ah, OK. Can we try the following? This will install old `red-arrow` when system Arrow GLib is old.
```diff
diff --git a/ci/scripts/glib_test.sh b/ci/scripts/glib_test.sh
index 51d955b..987cb17 100755
--- a/ci/scripts/glib_test.sh
+++ b/ci/scripts/glib_test.sh
@@ -74,6 +74,14 @@ test_subproject() {
gem_flags='-- --with-cflags="-D_LIBCPP_DISABLE_AVAILABILITY" --with-cppflags="-D_LIBCPP_DISABLE_AVAILABILITY"'
fi
+ arrow_glib_version=$(pkg-config --modversion arrow-glib | sed -e 's/-SNAPSHOT$//g' || :)
+ if [ -n "${arrow_glib_version}" ]; then
+ gem install \
+ --install-dir "${build_dir}/gems" \
+ --version ${arrow_glib_version} \
+ red-arrow \
+ -- ${gem_flags}
+ fi
gem install --install-dir "${build_dir}/gems" pkg/*.gem -- ${gem_flags}
popd
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #483: ci: pin red-arrow for now
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #483:
URL: https://github.com/apache/arrow-adbc/pull/483#discussion_r1122505307
##########
ruby/red-adbc.gemspec:
##########
@@ -52,7 +52,7 @@ Gem::Specification.new do |spec|
spec.files += Dir.glob("lib/**/*.rb")
spec.extensions = ["dependency-check/Rakefile"]
- spec.add_runtime_dependency("red-arrow")
+ spec.add_runtime_dependency("red-arrow", "<11.0.0")
Review Comment:
Unfortunately, I couldn't get CI to pass without it - one part of the tests is to install the gem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #483: ci: pin red-arrow for now
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #483:
URL: https://github.com/apache/arrow-adbc/pull/483#discussion_r1122505708
##########
ruby/red-adbc.gemspec:
##########
@@ -52,7 +52,7 @@ Gem::Specification.new do |spec|
spec.files += Dir.glob("lib/**/*.rb")
spec.extensions = ["dependency-check/Rakefile"]
- spec.add_runtime_dependency("red-arrow")
+ spec.add_runtime_dependency("red-arrow", "<11.0.0")
Review Comment:
As this is a known outstanding issue we can also just wait for the conda-forge PR to merge, and merge PRs in the meantime ignoring this issue. I can repurpose this PR to just switch to system meson
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #483: ci: make tests more robust to red-arrow/arrow-c-glib upgrades
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #483:
URL: https://github.com/apache/arrow-adbc/pull/483#discussion_r1123293503
##########
ruby/red-adbc.gemspec:
##########
@@ -52,7 +52,7 @@ Gem::Specification.new do |spec|
spec.files += Dir.glob("lib/**/*.rb")
spec.extensions = ["dependency-check/Rakefile"]
- spec.add_runtime_dependency("red-arrow")
+ spec.add_runtime_dependency("red-arrow", "<11.0.0")
Review Comment:
Thanks! Done. I also reverted the other changes and fixed up the Debian Dockerfile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #483: ci: make tests more robust to red-arrow/arrow-c-glib upgrades
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #483:
URL: https://github.com/apache/arrow-adbc/pull/483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #483: ci: pin red-arrow for now
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #483:
URL: https://github.com/apache/arrow-adbc/pull/483#discussion_r1122506523
##########
ruby/red-adbc.gemspec:
##########
@@ -52,7 +52,7 @@ Gem::Specification.new do |spec|
spec.files += Dir.glob("lib/**/*.rb")
spec.extensions = ["dependency-check/Rakefile"]
- spec.add_runtime_dependency("red-arrow")
+ spec.add_runtime_dependency("red-arrow", "<11.0.0")
Review Comment:
Especially since the upstream PR just merged, so we can wait a couple hours and see. Guess I was a little too eager here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] kou commented on a diff in pull request #483: ci: pin red-arrow for now
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #483:
URL: https://github.com/apache/arrow-adbc/pull/483#discussion_r1122489755
##########
ci/conda_env_glib.txt:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-arrow-c-glib
+arrow-c-glib<11.0.0
Review Comment:
We don't need this.
##########
ruby/red-adbc.gemspec:
##########
@@ -52,7 +52,7 @@ Gem::Specification.new do |spec|
spec.files += Dir.glob("lib/**/*.rb")
spec.extensions = ["dependency-check/Rakefile"]
- spec.add_runtime_dependency("red-arrow")
+ spec.add_runtime_dependency("red-arrow", "<11.0.0")
Review Comment:
Could you revert this?
This is used by users not test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org