[GitHub] [tvm] masahi commented on a change in pull request #9425: Fix repository URL in ubuntu_install_rocm.sh

[GitBox <gi...@apache.org>]

masahi commented on a change in pull request #9425:
URL: https://github.com/apache/tvm/pull/9425#discussion_r744017263



##########
File path: docker/install/ubuntu_install_rocm.sh
##########
@@ -21,10 +21,10 @@ set -u
 set -o pipefail
 
 # Install ROCm cross compilation toolchain.
-wget -qO - http://repo.radeon.com/rocm/apt/debian/rocm.gpg.key | sudo apt-key add -
-echo deb [arch=amd64] http://repo.radeon.com/rocm/apt/debian/ xenial main > /etc/apt/sources.list.d/rocm.list
+wget -qO - https://repo.radeon.com/rocm/rocm.gpg.key | sudo apt-key add -
+echo 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/4.3/ ubuntu main' | sudo tee /etc/apt/sources.list.d/rocm.list

Review comment:
       We don't have to use rocm's fork of llvm 13. Rocm 4.3 works fine




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org