You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/23 13:46:07 UTC

[GitHub] [arrow] milesgranger commented on a diff in pull request #14716: ARROW-18392: [Python] Fix test_s3fs_wrong_region; match when UNKNOWN

milesgranger commented on code in PR #14716:
URL: https://github.com/apache/arrow/pull/14716#discussion_r1030463465


##########
python/pyarrow/tests/test_fs.py:
##########
@@ -1321,22 +1321,23 @@ def test_s3fs_wrong_region():
     from pyarrow.fs import S3FileSystem
 
     # wrong region for bucket
-    fs = S3FileSystem(region='eu-north-1')
+    fs = S3FileSystem(region='eu-north-1', anonymous=True)

Review Comment:
   Done, and I found only one other test that uses a real AWS call, aptly named `test_s3_real_aws` but that already sets `anonymous=True`. All others appear to use the endpoint override / minio.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org