You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Abhishek Kumar <la...@gmail.com> on 2017/01/23 10:51:58 UTC
Review Request 55836: Hive View 2.0: Editor should be stretchable by
dragging
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55836/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-19667
https://issues.apache.org/jira/browse/AMBARI-19667
Repository: ambari
Description
-------
Added jQuery-ui to add "draggable" functionality
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 27d43d5
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 5ae65d1
contrib/views/hive20/src/main/resources/ui/bower.json 4eadee7
contrib/views/hive20/src/main/resources/ui/package.json ed7a299
Diff: https://reviews.apache.org/r/55836/diff/
Testing
-------
manually tested.
Thanks,
Abhishek Kumar
Re: Review Request 55836: Hive View 2.0: Editor should be stretchable
by dragging
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55836/#review162615
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Jan. 23, 2017, 10:51 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55836/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 10:51 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19667
> https://issues.apache.org/jira/browse/AMBARI-19667
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added jQuery-ui to add "draggable" functionality
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 27d43d5
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 5ae65d1
> contrib/views/hive20/src/main/resources/ui/bower.json 4eadee7
> contrib/views/hive20/src/main/resources/ui/package.json ed7a299
>
> Diff: https://reviews.apache.org/r/55836/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 55836: Hive View 2.0: Editor should be stretchable
by dragging
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55836/#review162777
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Jan. 23, 2017, 10:51 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55836/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 10:51 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19667
> https://issues.apache.org/jira/browse/AMBARI-19667
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added jQuery-ui to add "draggable" functionality
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 27d43d5
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 5ae65d1
> contrib/views/hive20/src/main/resources/ui/bower.json 4eadee7
> contrib/views/hive20/src/main/resources/ui/package.json ed7a299
>
> Diff: https://reviews.apache.org/r/55836/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 55836: Hive View 2.0: Editor should be stretchable
by dragging
Posted by Abhishek Kumar <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55836/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 6:27 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-19667
https://issues.apache.org/jira/browse/AMBARI-19667
Repository: ambari
Description
-------
Added jQuery-ui to add "draggable" functionality
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 27d43d5
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 0dae396
contrib/views/hive20/src/main/resources/ui/bower.json f4d9aa0
contrib/views/hive20/src/main/resources/ui/ember-cli-build.js 10e0402
Diff: https://reviews.apache.org/r/55836/diff/
Testing
-------
manually tested.
Thanks,
Abhishek Kumar
Re: Review Request 55836: Hive View 2.0: Editor should be stretchable
by dragging
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55836/#review162904
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Jan. 23, 2017, 10:51 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55836/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 10:51 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19667
> https://issues.apache.org/jira/browse/AMBARI-19667
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added jQuery-ui to add "draggable" functionality
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 27d43d5
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 5ae65d1
> contrib/views/hive20/src/main/resources/ui/bower.json 4eadee7
> contrib/views/hive20/src/main/resources/ui/package.json ed7a299
>
> Diff: https://reviews.apache.org/r/55836/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Abhishek Kumar
>
>