You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Olga Smola <ol...@gmail.com> on 2012/06/29 11:04:12 UTC
Review Request: CS-15391: Missing required fields velidation when Edit on
the Details tab for Infrastructure/Zones, Infrastructure/Pods.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5657/
-----------------------------------------------------------
Review request for cloudstack and Sanjay Tripathi.
Description
-------
Hi Sanjay,
Could you please review the ticket http://bugs.cloudstack.org/browse/CS-15391
It's similar to the http://bugs.cloudstack.org/browse/CS-15287
I've assign this ticket to you, because Brian Federle said, that you were working on some validation issues previously.
Thanks, Olga
This addresses bug CS-15391.
Diffs
-----
ui/scripts/system.js 6d3b765
Diff: https://reviews.apache.org/r/5657/diff/
Testing
-------
Thanks,
Olga Smola
Re: Review Request: CS-15391: Missing required fields velidation when Edit
on the Details tab for Infrastructure/Zones, Infrastructure/Pods.
Posted by Olga Smola <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5657/
-----------------------------------------------------------
(Updated July 11, 2012, 3:29 p.m.)
Review request for cloudstack, Sanjay Tripathi and Brian Federle.
Changes
-------
Added Brian Federle as reviewer.
Description
-------
Hi Sanjay,
Could you please review the ticket http://bugs.cloudstack.org/browse/CS-15391
It's similar to the http://bugs.cloudstack.org/browse/CS-15287
I've assign this ticket to you, because Brian Federle said, that you were working on some validation issues previously.
Thanks, Olga
This addresses bug CS-15391.
Diffs
-----
ui/scripts/system.js 6d3b765
Diff: https://reviews.apache.org/r/5657/diff/
Testing
-------
Thanks,
Olga Smola
Re: Review Request: CS-15391: Missing required fields velidation when
Edit on the Details tab for Infrastructure/Zones, Infrastructure/Pods.
Posted by Olga Smola <ol...@gmail.com>.
Hi Sanjay,
thank you for feedback. Yes, I've already added validation for "Edit panel"
but previously I've missed validation for some sections, that's why created
another ticket when found sections without validation.
Best regards,
Olga
On Fri, Jun 29, 2012 at 1:56 PM, Sanjay Tripathi <sanjay.tripathi@citrix.com
> wrote:
> Hi Olga,****
>
> ** **
>
> I reviewed your code and the patch is working fine. Assigned the ticket to
> Brian for the final review.****
>
> Looks like you already covered all the areas for “edit panel” fields
> validation, in case if you find any field needs validation, please file the
> bug for the same.****
>
> Good Work!!****
>
> ** **
>
> Thanks and Regards,****
>
> Sanjay Tripathi****
>
> ** **
>
> *From:* Olga Smola [mailto:noreply@reviews.apache.org] *On Behalf Of *Olga
> Smola
> *Sent:* Friday, June 29, 2012 2:34 PM
> *To:* Sanjay Tripathi
> *Cc:* cloudstack; Olga Smola
> *Subject:* Review Request: CS-15391: Missing required fields velidation
> when Edit on the Details tab for Infrastructure/Zones, Infrastructure/Pods.
> ****
>
> ** **
>
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5657/ ****
>
> ** **
>
> Review request for cloudstack and Sanjay Tripathi.****
>
> By Olga Smola.****
> Description ****
>
> Hi Sanjay,****
>
> ** **
>
> Could you please review the ticket http://bugs.cloudstack.org/browse/CS-15391****
>
> It's similar to the http://bugs.cloudstack.org/browse/CS-15287****
>
> I've assign this ticket to you, because Brian Federle said, that you were working on some validation issues previously.****
>
> ** **
>
> Thanks, Olga****
>
> *Bugs: *CS-15391 ****
> Diffs ****
>
> - ui/scripts/system.js (6d3b765)****
>
> View Diff <https://reviews.apache.org/r/5657/diff/>****
>
> ** **
>
RE: Review Request: CS-15391: Missing required fields velidation
when Edit on the Details tab for Infrastructure/Zones, Infrastructure/Pods.
Posted by Sanjay Tripathi <sa...@citrix.com>.
Hi Olga,
I reviewed your code and the patch is working fine. Assigned the ticket to Brian for the final review.
Looks like you already covered all the areas for “edit panel” fields validation, in case if you find any field needs validation, please file the bug for the same.
Good Work!!
Thanks and Regards,
Sanjay Tripathi
From: Olga Smola [mailto:noreply@reviews.apache.org] On Behalf Of Olga Smola
Sent: Friday, June 29, 2012 2:34 PM
To: Sanjay Tripathi
Cc: cloudstack; Olga Smola
Subject: Review Request: CS-15391: Missing required fields velidation when Edit on the Details tab for Infrastructure/Zones, Infrastructure/Pods.
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5657/
Review request for cloudstack and Sanjay Tripathi.
By Olga Smola.
Description
Hi Sanjay,
Could you please review the ticket http://bugs.cloudstack.org/browse/CS-15391
It's similar to the http://bugs.cloudstack.org/browse/CS-15287
I've assign this ticket to you, because Brian Federle said, that you were working on some validation issues previously.
Thanks, Olga
Bugs: CS-15391
Diffs
* ui/scripts/system.js (6d3b765)
View Diff<https://reviews.apache.org/r/5657/diff/>