You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@s2graph.apache.org by "DOYUNG YOON (JIRA)" <ji...@apache.org> on 2018/06/11 03:38:00 UTC

[jira] [Created] (S2GRAPH-220) Filter clause is not working on AnnoyModelFetcher

DOYUNG YOON created S2GRAPH-220:
-----------------------------------

             Summary: Filter clause is not working on AnnoyModelFetcher
                 Key: S2GRAPH-220
                 URL: https://issues.apache.org/jira/browse/S2GRAPH-220
             Project: S2Graph
          Issue Type: Bug
          Components: s2core, s2graphql
            Reporter: DOYUNG YOON


Below query should filter all edges that have property 'score' smaller than 0.1 but current implementation return edges with larger score property value than 0.1.


{noformat}
{
  s2graph {
    user(id: 0) {
      friends(limit: 10, filter: "score < 0.1") {
        user {
          id
        }
      }
    }
  }
}
{noformat}

After a look through the current master, I found out Where parser and EdgeTransformer are processed on AsynchbaseEdgeFetcher and RocksEdgeFetcher by calling StorageIO.toEdges method, but this is missing on AnnoyModelFetcher.

I suggest to extract `Where` and `EdgeTransformer` from StorageIO.toEdges to helper so other Fetcher implementation can easily use this helper to apply them correctly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)