You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/10/22 05:39:39 UTC

[GitHub] [incubator-ratis] runzhiwang commented on a change in pull request #230: RATIS-1104.Should check "bytewritten" from remote writes to peers to determine whether current stream write is successful

runzhiwang commented on a change in pull request #230:
URL: https://github.com/apache/incubator-ratis/pull/230#discussion_r509891703



##########
File path: ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -211,6 +219,17 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws IOExceptio
 
         JavaUtils.allOf(remoteWrites).thenCombine(localWrite, (v, bytesWritten) -> {
               buf.release();
+              for (CompletableFuture<DataStreamReply> replyFuture : remoteWrites) {

Review comment:
       Please define another method to do this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org