You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/09 23:22:59 UTC
[GitHub] [tvm] driazati opened a new pull request, #11258: [ci] Use r5.large nodes for builds and lint
driazati opened a new pull request, #11258:
URL: https://github.com/apache/tvm/pull/11258
This uses `r5.large` for linting and build steps and splits lint into 2 to keep runtime down. This is a subset split off of #11120. Once `task_cpp_unittest.sh` is fixed so it picks up sccache we can enable these smaller nodes there as well.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #11258: [ci] Use r5.large nodes for builds and lint
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #11258:
URL: https://github.com/apache/tvm/pull/11258#discussion_r869530845
##########
tests/scripts/task_lint.sh:
##########
@@ -25,48 +25,69 @@ cleanup()
trap cleanup 0
-echo "Convert scripts to Python..."
-tests/scripts/task_convert_scripts_to_python.sh
+# These shards are solely for CI to enable the lint job to have some parallelism.
-# TODO: Remove this ad-hoc pip install once https://github.com/apache/tvm/pull/10741
-# is added to the ci_lint Docker image
-python3 -m pip install --user -r jenkins/requirements.txt
-echo "Check Jenkinsfile generation"
-python3 jenkins/generate.py --check
+function shard1 {
+ echo "Convert scripts to Python..."
+ tests/scripts/task_convert_scripts_to_python.sh
-echo "Checking file types..."
-python3 tests/lint/check_file_type.py
+ # TODO: Remove this ad-hoc pip install once https://github.com/apache/tvm/pull/10741
Review Comment:
~~Yup you're right, we don't need this anymore~~ actually this was added incorrectly, #11265 should fix it but that shouldn't block this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #11258: [ci] Use r5.large nodes for builds and lint
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #11258:
URL: https://github.com/apache/tvm/pull/11258#discussion_r869530845
##########
tests/scripts/task_lint.sh:
##########
@@ -25,48 +25,69 @@ cleanup()
trap cleanup 0
-echo "Convert scripts to Python..."
-tests/scripts/task_convert_scripts_to_python.sh
+# These shards are solely for CI to enable the lint job to have some parallelism.
-# TODO: Remove this ad-hoc pip install once https://github.com/apache/tvm/pull/10741
-# is added to the ci_lint Docker image
-python3 -m pip install --user -r jenkins/requirements.txt
-echo "Check Jenkinsfile generation"
-python3 jenkins/generate.py --check
+function shard1 {
+ echo "Convert scripts to Python..."
+ tests/scripts/task_convert_scripts_to_python.sh
-echo "Checking file types..."
-python3 tests/lint/check_file_type.py
+ # TODO: Remove this ad-hoc pip install once https://github.com/apache/tvm/pull/10741
Review Comment:
Yup you're right, we don't need this anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on a diff in pull request #11258: [ci] Use r5.large nodes for builds and lint
Posted by GitBox <gi...@apache.org>.
Mousius commented on code in PR #11258:
URL: https://github.com/apache/tvm/pull/11258#discussion_r869074382
##########
tests/scripts/task_lint.sh:
##########
@@ -25,48 +25,69 @@ cleanup()
trap cleanup 0
-echo "Convert scripts to Python..."
-tests/scripts/task_convert_scripts_to_python.sh
+# These shards are solely for CI to enable the lint job to have some parallelism.
-# TODO: Remove this ad-hoc pip install once https://github.com/apache/tvm/pull/10741
-# is added to the ci_lint Docker image
-python3 -m pip install --user -r jenkins/requirements.txt
-echo "Check Jenkinsfile generation"
-python3 jenkins/generate.py --check
+function shard1 {
+ echo "Convert scripts to Python..."
+ tests/scripts/task_convert_scripts_to_python.sh
-echo "Checking file types..."
-python3 tests/lint/check_file_type.py
+ # TODO: Remove this ad-hoc pip install once https://github.com/apache/tvm/pull/10741
Review Comment:
I think this has now landed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #11258: [ci] Use r5.large nodes for builds and lint
Posted by GitBox <gi...@apache.org>.
Mousius commented on PR #11258:
URL: https://github.com/apache/tvm/pull/11258#issuecomment-1123375101
Thanks @driazati!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius merged pull request #11258: [ci] Use r5.large nodes for builds and lint
Posted by GitBox <gi...@apache.org>.
Mousius merged PR #11258:
URL: https://github.com/apache/tvm/pull/11258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org