[jira] [Commented] (FLINK-4074) Reporter can block TaskManager shutdown

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331583#comment-15331583 ] 

ASF GitHub Bot commented on FLINK-4074:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2105

    [FLINK-4074] Make metric reporters less blocking

    - adds a cancel flag to the StatsDReporter, which is checked before sending every metric. set to true when stop() is called.
    - switched from Timer to ScheduledExecutorService, in the hopes of better forced termination.
    - also contains a hotfix preventing exceptions occurring in (un)register to be propagated

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink metrics_blocking_reporter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2105
    
----
commit 47ae329fff1973e3de9c00f0352a984bb1dba17d
Author: zentol <ch...@apache.org>
Date:   2016-06-15T10:23:41Z

    [FLINK-4074] Make metric reporters less blocking

commit d6e9ce495ff420a3d454e1e35fe72507db03ae27
Author: zentol <ch...@apache.org>
Date:   2016-06-15T10:17:22Z

    [hotfix] [metrics] Prevent registration exceptions

----


> Reporter can block TaskManager shutdown
> ---------------------------------------
>
>                 Key: FLINK-4074
>                 URL: https://issues.apache.org/jira/browse/FLINK-4074
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> If a report is being submitted while a TaskManager is shutting down the reporter can cause the shutdown to be delayed since it submits the complete report.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)