You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lordcheng10 (via GitHub)" <gi...@apache.org> on 2023/03/22 06:36:06 UTC

[GitHub] [pulsar] lordcheng10 opened a new pull request, #19893: [imporve][broker] use shortTermMsgRate and shortTermThroughput for UniformLoadShedder

lordcheng10 opened a new pull request, #19893:
URL: https://github.com/apache/pulsar/pull/19893

   ### Motivation
   In UniformLoadShedder, when selecting overloadedBroker and underloadedBroker, use shortTermThroughput and shortTermMsgRate.
   
   
   
   ### Modifications
   
   In UniformLoadShedder, when selecting overloadedBroker and underloadedBroker, use shortTermThroughput and shortTermMsgRate.
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository:  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] AnonHxy commented on pull request #19893: [imporve][broker] use shortTermMsgRate and shortTermThroughput for UniformLoadShedder

Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on PR #19893:
URL: https://github.com/apache/pulsar/pull/19893#issuecomment-1480775416

   > It's better to provide the details of Motivation
   
   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [imporve][broker] use shortTermMsgRate and shortTermThroughput for UniformLoadShedder [pulsar]

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat closed pull request #19893: [imporve][broker] use shortTermMsgRate and shortTermThroughput for UniformLoadShedder
URL: https://github.com/apache/pulsar/pull/19893


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [imporve][broker] use shortTermMsgRate and shortTermThroughput for UniformLoadShedder [pulsar]

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on PR #19893:
URL: https://github.com/apache/pulsar/pull/19893#issuecomment-6182312220

   Hi @lordcheng10, thanks for the contribution. Switching UniformLoadShedder to the short-term averages changes how brokers are picked for shedding. The reviewers asked for more detail on the motivation, and since we never got it, the PR didn't move forward. We're going through the backlog of open PRs (https://lists.apache.org/thread/cgy7w0qgnq8s7j0ykyzgrn3hj4nb67wf), so I'm closing this one. If you'd like to continue, feel free to reopen it rebased on current master, with a description of the problem you saw.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] aloyszhang commented on pull request #19893: [imporve][broker] use shortTermMsgRate and shortTermThroughput for UniformLoadShedder

Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on PR #19893:
URL: https://github.com/apache/pulsar/pull/19893#issuecomment-1479200809

   It's better to provide the details of Motivation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #19893: [imporve][broker] use shortTermMsgRate and shortTermThroughput for UniformLoadShedder

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19893:
URL: https://github.com/apache/pulsar/pull/19893#issuecomment-1518918299

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org