[GitHub] [geode] DonalEvans commented on a change in pull request #6883: GEODE-9547: Radish commands are authorized by the SecurityManager

[GitBox <gi...@apache.org>]

DonalEvans commented on a change in pull request #6883:
URL: https://github.com/apache/geode/pull/6883#discussion_r713174377



##########
File path: geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/connection/AuthIntegrationTest.java
##########
@@ -53,22 +54,33 @@ public int getPort() {
     return port;
   }
 
+  @Override
+  public String getUsername() {
+    return "dataWrite";
+  }
+
+  @Override
+  public String getPassword() {
+    return "dataWrite";
+  }
+
   public void setupCacheWithSecurity() throws Exception {
-    setupCache(true, true);
+    setupCache(getUsername(), true);
   }
 
   public void setupCacheWithoutSecurity() throws Exception {
-    setupCache(false, false);
+    setupCache(null, false);
   }
 
-  private void setupCache(boolean withUsername, boolean withSecurityManager) throws Exception {
+  private void setupCache(String username, boolean withSecurityManager) throws Exception {
+    System.setProperty("io.netty.eventLoopThreads", "1");

Review comment:
       What is the purpose of setting this property?

##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/RedisResponse.java
##########
@@ -149,14 +149,14 @@ public static RedisResponse wrongpass(String error) {
     return new RedisResponse((bba) -> Coder.getWrongpassResponse(bba, error));
   }
 
-  public static RedisResponse customError(String error) {
-    return new RedisResponse((buffer) -> Coder.getCustomErrorResponse(buffer, error));
-  }
-

Review comment:
       With this change, the `Coder.getCustomErrorResponse()` is no longer used. Could it be removed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org