You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2013/05/10 20:52:57 UTC
git commit: [flex-sdk] [refs/heads/develop] - add .gitignore for
mustella generated files
Updated Branches:
refs/heads/develop a4cb8041f -> 9f21583b8
add .gitignore for mustella generated files
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/9f21583b
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/9f21583b
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/9f21583b
Branch: refs/heads/develop
Commit: 9f21583b830ee8814be9034e6ca2b8f7096c7f23
Parents: a4cb804
Author: Alex Harui <ah...@apache.org>
Authored: Fri May 10 11:52:33 2013 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Fri May 10 11:52:33 2013 -0700
----------------------------------------------------------------------
mustella/.gitignore | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/9f21583b/mustella/.gitignore
----------------------------------------------------------------------
diff --git a/mustella/.gitignore b/mustella/.gitignore
new file mode 100644
index 0000000..b47f0dd
--- /dev/null
+++ b/mustella/.gitignore
@@ -0,0 +1,8 @@
+# mustella files
+failures.txt
+results.txt
+properties/mustella_tmp.properties
+test_files.tmp
+*.lnk.xml
+*.bad.png
+*.bad.png.xml
Re: git commit: [flex-sdk] [refs/heads/develop] - add .gitignore for mustella generated files
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Sorry I meant to say "to have them out of git ignore" not in.
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - add .gitignore for
mustella generated files
Posted by OmPrakash Muppirala <bi...@gmail.com>.
Is this a good time to talk about moving Mustella out of the sdk repo?
On May 10, 2013 9:35 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
>
>
> On 5/10/13 5:29 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>
> > Hi,
> >
> >> I see. But shouldn't we rely on the mustella console output? That's
> what we
> >> did when in SVN.
> > At the time you run the test sure, but you may forget which one failed
> after
> > fixing a bug or two and git status is a lot lot faster than rerunning the
> > tests.
> That presumes the test failed with a bitmap failure which isn't always the
> case. And each run cleans up bad.pngs from prior runs beforehand.
>
> I suppose we could try taking failures.txt out of the gitignore and
> changing
> mini_run to delete it if there are no failures, but even then, it will only
> show you if your last run failed.
> >
> > Given that no one is likely to check these files in and they indicate an
> issue
> > than needs to be fixed I think it's safer to have have them in
> .gitignore.
> You can remove them from gitignore if you want, but just realize that their
> existence is not a foolproof way of knowing you have failing tests.
> >
> > Thanks,
> > Justin
>
> --
> Alex Harui
> Flex SDK Team
> Adobe Systems, Inc.
> http://blogs.adobe.com/aharui
>
>
Re: git commit: [flex-sdk] [refs/heads/develop] - add .gitignore
for mustella generated files
Posted by Alex Harui <ah...@adobe.com>.
On 5/10/13 5:29 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
> Hi,
>
>> I see. But shouldn't we rely on the mustella console output? That's what we
>> did when in SVN.
> At the time you run the test sure, but you may forget which one failed after
> fixing a bug or two and git status is a lot lot faster than rerunning the
> tests.
That presumes the test failed with a bitmap failure which isn't always the
case. And each run cleans up bad.pngs from prior runs beforehand.
I suppose we could try taking failures.txt out of the gitignore and changing
mini_run to delete it if there are no failures, but even then, it will only
show you if your last run failed.
>
> Given that no one is likely to check these files in and they indicate an issue
> than needs to be fixed I think it's safer to have have them in .gitignore.
You can remove them from gitignore if you want, but just realize that their
existence is not a foolproof way of knowing you have failing tests.
>
> Thanks,
> Justin
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: git commit: [flex-sdk] [refs/heads/develop] - add .gitignore for mustella generated files
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I see. But shouldn't we rely on the mustella console output? That's what we
> did when in SVN.
At the time you run the test sure, but you may forget which one failed after fixing a bug or two and git status is a lot lot faster than rerunning the tests.
Given that no one is likely to check these files in and they indicate an issue than needs to be fixed I think it's safer to have have them in .gitignore.
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - add .gitignore
for mustella generated files
Posted by Alex Harui <ah...@adobe.com>.
On 5/10/13 5:14 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
> Hi,
>
>> Why do we want to have the bad test results in version control?
> We don't want them in Git - but by adding them to git ignore means that are
> also ignored by "git status" etc which means you may not be aware that you
> have tests that failed when checking stuff in.
I see. But shouldn't we rely on the mustella console output? That's what we
did when in SVN. Is there a need to be better?
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: git commit: [flex-sdk] [refs/heads/develop] - add .gitignore for mustella generated files
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Why do we want to have the bad test results in version control?
We don't want them in Git - but by adding them to git ignore means that are also ignored by "git status" etc which means you may not be aware that you have tests that failed when checking stuff in.
Thanks,
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - add .gitignore
for mustella generated files
Posted by Alex Harui <ah...@adobe.com>.
Maybe I don't understand git. I thought the purpose of .gitignore was so it
would not offer to check in files we don't want to see under version
control. Why do we want to have the bad test results in version control?
On 5/10/13 3:52 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
> Hi,
>
> Hiding broken tests from git seems like a bad idea to me.
>
>> +*.bad.png
>> +*.bad.png.xml
>
> Justin
>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: git commit: [flex-sdk] [refs/heads/develop] - add .gitignore for mustella generated files
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Hiding broken tests from git seems like a bad idea to me.
> +*.bad.png
> +*.bad.png.xml
Justin