You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2026/02/20 15:33:02 UTC
[PR] [SPARK-54835][SQL][FOLLOWUP] Drain listener bus before registering listener in test [spark]
cloud-fan opened a new pull request, #54397:
URL: https://github.com/apache/spark/pull/54397
### What changes were proposed in this pull request?
This is a followup to #53596. In the test "CTAS/RTAS should trigger two query executions", we drain the listener bus before registering the `QueryExecutionListener`, to avoid events from other tests breaking this test with unexpected `executionCount` increments.
### Why are the changes needed?
Without draining the listener bus first, pending events from previous tests could fire after the listener is registered, causing flaky test failures. Other test suites follow this same pattern.
### Does this PR introduce _any_ user-facing change?
No. Test-only change.
### How was this patch tested?
Existing test.
### Was this patch authored or co-authored using generative AI tooling?
Yes.
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54835][SQL][TESTS][FOLLOWUP] Drain listener bus before registering listener in test [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #54397: [SPARK-54835][SQL][TESTS][FOLLOWUP] Drain listener bus before registering listener in test
URL: https://github.com/apache/spark/pull/54397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54835][SQL][TESTS][FOLLOWUP] Drain listener bus before registering listener in test [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54397:
URL: https://github.com/apache/spark/pull/54397#issuecomment-3936293450
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54835][SQL][FOLLOWUP] Drain listener bus before registering listener in test [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #54397:
URL: https://github.com/apache/spark/pull/54397#issuecomment-3935626273
@pan3793 @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org