[GitHub] [nifi] bbende commented on a change in pull request #5659: NIFI-9570 Updating AWS SDK version for NiFi Registry AWS extension mo…

[GitBox <gi...@apache.org>]

bbende commented on a change in pull request #5659:
URL: https://github.com/apache/nifi/pull/5659#discussion_r786808384



##########
File path: nifi-registry/nifi-registry-extensions/nifi-registry-aws/pom.xml
##########
@@ -30,7 +30,7 @@
     </modules>
 
     <properties>
-        <aws-java-sdk-version>2.5.9</aws-java-sdk-version>
+        <aws-java-sdk-version>2.17.106</aws-java-sdk-version>

Review comment:
       Since everything is in the same repository now, the root pom is the common parent so we can have this property defined there and shared if we want. The reason I didn't do this initially was because I view this fix as somewhat temporary, the real solution is to figure out a way for all of these AWS/Azure/GCP JARs to not end up in the lib directory of NiFi Registry (or NiFi bootstrap). We didn't intend for NiFi Registry's S3BundlePersistenceProvider to need to use the same AWS client version as NiFi's sensitive property provider, but currently it has to due to the way things are setup.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org