You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/04/15 18:22:14 UTC

[jira] Created: (CASSANDRA-83) fixed remove is not exposed in the thrift interface

fixed remove is not exposed in the thrift interface
---------------------------------------------------

                 Key: CASSANDRA-83
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-83
             Project: Cassandra
          Issue Type: Bug
            Reporter: Jonathan Ellis
            Assignee: Jonathan Ellis




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-83) fixed remove is not exposed in the thrift interface

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-83.
-------------------------------------

    Resolution: Fixed

committed w/ suggested change to `bool block` instead of `int block_for`

> fixed remove is not exposed in the thrift interface
> ---------------------------------------------------
>
>                 Key: CASSANDRA-83
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-83
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>         Attachments: 83.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-83) fixed remove is not exposed in the thrift interface

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699743#action_12699743 ] 

Jun Rao commented on CASSANDRA-83:
----------------------------------

Shouldn't block_for in the remove thrift api be bool instead of int? Other than that, the patch works fine.

> fixed remove is not exposed in the thrift interface
> ---------------------------------------------------
>
>                 Key: CASSANDRA-83
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-83
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>         Attachments: 83.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-83) fixed remove is not exposed in the thrift interface

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-83:
------------------------------------

    Attachment: 83.patch

block_for is binary in nature: 0 = do not block (return value is meaningless), > 0 = block for majority (return value is success)

> fixed remove is not exposed in the thrift interface
> ---------------------------------------------------
>
>                 Key: CASSANDRA-83
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-83
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>         Attachments: 83.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-83) fixed remove is not exposed in the thrift interface

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699748#action_12699748 ] 

Jonathan Ellis commented on CASSANDRA-83:
-----------------------------------------

right -- I want it to be an int eventually though.  (1, majority, and all are values that all make sense there.)

guess you are right that it should be a bool until that's actually implemented though.

> fixed remove is not exposed in the thrift interface
> ---------------------------------------------------
>
>                 Key: CASSANDRA-83
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-83
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>         Attachments: 83.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.