You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by cakofony <gi...@git.apache.org> on 2018/02/14 19:08:14 UTC

[GitHub] logging-log4j2 pull request #149: ReusableMessage implementations no longer ...

GitHub user cakofony opened a pull request:

    https://github.com/apache/logging-log4j2/pull/149

    ReusableMessage implementations no longer allocate for 0-len params

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cakofony/logging-log4j2 reusable_message_getparams_allocation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #149
    
----
commit a62583c1ca65fb00bd9224c26c351cef841806c7
Author: Carter Kozak <c4...@...>
Date:   2018-02-14T19:07:24Z

    ReusableMessage implementations no longer allocate for 0-len params

----


---

[GitHub] logging-log4j2 issue #149: ReusableMessage implementations no longer allocat...

Posted by garydgregory <gi...@git.apache.org>.

Github user garydgregory commented on the issue:

    https://github.com/apache/logging-log4j2/pull/149
  
    Thank you for the PR. That's a lot of duplicated code (relatively). Can the empty array and new expression be refactored in a common site?


---

[GitHub] logging-log4j2 issue #149: ReusableMessage implementations no longer allocat...

Posted by cakofony <gi...@git.apache.org>.

Github user cakofony commented on the issue:

    https://github.com/apache/logging-log4j2/pull/149
  
    Yep, updated.


---

[GitHub] logging-log4j2 issue #149: ReusableMessage implementations no longer allocat...

Posted by cakofony <gi...@git.apache.org>.

Github user cakofony commented on the issue:

    https://github.com/apache/logging-log4j2/pull/149
  
    This isn't as important to me now that we have #150 
    I can rebase this PR if you think it's still helpful, otherwise feel free to close it out!


---

[GitHub] logging-log4j2 pull request #149: ReusableMessage implementations no longer ...

Posted by cakofony <gi...@git.apache.org>.

Github user cakofony closed the pull request at:

    https://github.com/apache/logging-log4j2/pull/149


---