You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/22 07:23:05 UTC
[GitHub] [incubator-kvrocks] git-hulk opened a new issue, #908: Use Lua vm by default instead of LuaJIT
git-hulk opened a new issue, #908:
URL: https://github.com/apache/incubator-kvrocks/issues/908
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
### Motivation
LuaJIT can improve the performance a lot in compute intensive scenario,
but we didn't test carefully about compatible. So I think we can use the Lua
VM by default and guide user to enable it if they need it.
cc @xiaobiaozhao
### Solution
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] xiaobiaozhao commented on issue #908: Use Lua vm by default instead of LuaJIT
Posted by GitBox <gi...@apache.org>.
xiaobiaozhao commented on issue #908:
URL: https://github.com/apache/incubator-kvrocks/issues/908#issuecomment-1256307779
I don't think there's any question about Luajit's stability. However, if turned on luajit as the default switch, it is not friendly to users who upgrade directly. An important tip for users who need high performance is to enable Luajit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #908: Use Lua vm by default instead of LuaJIT
Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #908:
URL: https://github.com/apache/incubator-kvrocks/issues/908#issuecomment-1256037641
Yes, my concern is we didn't have enough test cases to prove the LuaJIT compatibility, so I think it's too rush to replacing Lua VM in the next release. Besides, I think it's fine to enable by default if it's totally a new feature and useful for most users.
Does it sound good to disable by default in next release, I will contact and push users what I know to have a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on issue #908: Use Lua vm by default instead of LuaJIT
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #908:
URL: https://github.com/apache/incubator-kvrocks/issues/908#issuecomment-1256021360
@git-hulk is there a real use case for this claim? LuaJIT passes all our test cases and if we don't enable new feature by default, it will hardly get feedback to be solid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #908: Use Lua vm by default instead of LuaJIT
Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #908:
URL: https://github.com/apache/incubator-kvrocks/issues/908#issuecomment-1256123909
Yes, agree we should enable new features by default if possible. But it's our first release to involve LuaJIT. so I think it will be better to let users know and try it first, then we can claim clearly that we will enable by default in the next feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on issue #908: Use Lua vm by default instead of LuaJIT
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #908:
URL: https://github.com/apache/incubator-kvrocks/issues/908#issuecomment-1256116379
@git-hulk It's reasonable to have a clear signal of stability; otherwise, it's a "pocket" to prevent enabling the feature by default. For example, Flink supports RegionFailoverStrategy in 1.9 and has a determinate target to enable it by default in 1.11. So contributors are encouraged to polish the feature since it _will_ be pushed to production.
Besides, a well-written release note will highlight this change and users should upgrade with awareness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org