You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2018/11/15 22:11:29 UTC
[GitHub] nifi-minifi-cpp pull request #442: MINIFICPP-679: Make minor changes for con...
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/442
MINIFICPP-679: Make minor changes for const correctness improvements
Running a windows build now. If I see errors there I'll re-submit, but ran general tests and build across a variety of platforms.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-679
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/442.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #442
----
commit 12fe6ccdf163bc585425df28e6bbc7f5cfb6347f
Author: Marc Parisi <ph...@...>
Date: 2018-11-15T22:10:42Z
MINIFICPP-679: Make minor changes for const correctness improvements
----
---
[GitHub] nifi-minifi-cpp pull request #442: MINIFICPP-679: Make minor changes for con...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/442#discussion_r234040428
--- Diff: libminifi/include/core/Core.h ---
@@ -142,52 +141,30 @@ class CoreComponent {
* Constructor that sets the name and uuid.
*/
- explicit CoreComponent(const std::string name, utils::Identifier uuid)
+ explicit CoreComponent(const std::string &name, utils::Identifier uuid)
: name_(name) {
if (uuid == nullptr) {
// Generate the global UUID for the flow record
id_generator_->generate(uuid_);
} else {
uuid_ = uuid;
}
-
uuidStr_ = uuid_.to_string();
}
- explicit CoreComponent(const std::string name)
+ explicit CoreComponent(const std::string &name)
: name_(name) {
-
// Generate the global UUID for the flow record
id_generator_->generate(uuid_);
-
uuidStr_ = uuid_.to_string();
}
- /*
- #ifdef WIN32
- #else
-
- explicit CoreComponent(const std::string name, Identifier uuid = nullptr)
- : name_(name) {
- if (nullptr == uuid)
- // Generate the global UUID for the flow record
- id_generator_->generate(uuid_);
- else
- uuid_copy(uuid_, uuid);
-
- char uuidStr[37] = { 0 };
- uuid_unparse_lower(uuid_, uuidStr);
- uuidStr_ = uuidStr;
- }
- #endif
- */
+
+ explicit CoreComponent(const CoreComponent &other) = default;
/**
* Move Constructor.
*/
- explicit CoreComponent(const CoreComponent &&other)
- : name_(std::move(other.name_)) {
- uuid_ = other.uuid_;
- //uuid_copy(uuid_, other.uuid_);
- }
+
--- End diff --
should be safe since we added a non trial move con to ident, but this will require some testing on all platforms. again, still running windows build. Will probably report back tomorrow.
---
[GitHub] nifi-minifi-cpp pull request #442: MINIFICPP-679: Make minor changes for con...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/442
---