You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Ari Rabkin (JIRA)" <ji...@apache.org> on 2009/01/30 05:24:59 UTC

[jira] Created: (HADOOP-5147) remove refs to slaves file

remove refs to slaves file
--------------------------

                 Key: HADOOP-5147
                 URL: https://issues.apache.org/jira/browse/HADOOP-5147
             Project: Hadoop Core
          Issue Type: Improvement
          Components: contrib/chukwa
            Reporter: Ari Rabkin
            Priority: Minor
         Attachments: betterbin.patch

The Chukwa bin scripts refer to conf/slaves.  This should be conf/chukwa-agents.
Further, stop-agents should not touch cron, since start-agents doesn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5147) remove refs to slaves file

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673983#action_12673983 ] 

Hudson commented on HADOOP-5147:
--------------------------------

Integrated in Hadoop-trunk #756 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/])
    

> remove refs to slaves file
> --------------------------
>
>                 Key: HADOOP-5147
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5147
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: betterbin.patch
>
>
> The Chukwa bin scripts refer to conf/slaves.  This should be conf/chukwa-agents.
> Further, stop-agents should not touch cron, since start-agents doesn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5147) remove refs to slaves file

Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ari Rabkin updated HADOOP-5147:
-------------------------------

    Attachment:     (was: betterbin.patch)

> remove refs to slaves file
> --------------------------
>
>                 Key: HADOOP-5147
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5147
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>
> The Chukwa bin scripts refer to conf/slaves.  This should be conf/chukwa-agents.
> Further, stop-agents should not touch cron, since start-agents doesn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5147) remove refs to slaves file

Posted by "Andy Konwinski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670933#action_12670933 ] 

Andy Konwinski commented on HADOOP-5147:
----------------------------------------

+1 the shell script should have been named this way in the first place

> remove refs to slaves file
> --------------------------
>
>                 Key: HADOOP-5147
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5147
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>         Attachments: betterbin.patch
>
>
> The Chukwa bin scripts refer to conf/slaves.  This should be conf/chukwa-agents.
> Further, stop-agents should not touch cron, since start-agents doesn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5147) remove refs to slaves file

Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ari Rabkin updated HADOOP-5147:
-------------------------------

    Attachment: betterbin.patch

previous patch was against $CHUKWA_HOME, not against Hadoop rootdir.  This 

> remove refs to slaves file
> --------------------------
>
>                 Key: HADOOP-5147
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5147
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>         Attachments: betterbin.patch
>
>
> The Chukwa bin scripts refer to conf/slaves.  This should be conf/chukwa-agents.
> Further, stop-agents should not touch cron, since start-agents doesn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5147) remove refs to slaves file

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-5147:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I committed this. Thanks, Ari

> remove refs to slaves file
> --------------------------
>
>                 Key: HADOOP-5147
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5147
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: betterbin.patch
>
>
> The Chukwa bin scripts refer to conf/slaves.  This should be conf/chukwa-agents.
> Further, stop-agents should not touch cron, since start-agents doesn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5147) remove refs to slaves file

Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ari Rabkin updated HADOOP-5147:
-------------------------------

    Assignee: Ari Rabkin
      Status: Patch Available  (was: Open)

> remove refs to slaves file
> --------------------------
>
>                 Key: HADOOP-5147
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5147
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>         Attachments: betterbin.patch
>
>
> The Chukwa bin scripts refer to conf/slaves.  This should be conf/chukwa-agents.
> Further, stop-agents should not touch cron, since start-agents doesn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5147) remove refs to slaves file

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669829#action_12669829 ] 

Eric Yang commented on HADOOP-5147:
-----------------------------------

+1 filename change in shell script.  This change makes the file name more clearly defined.

> remove refs to slaves file
> --------------------------
>
>                 Key: HADOOP-5147
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5147
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>         Attachments: betterbin.patch
>
>
> The Chukwa bin scripts refer to conf/slaves.  This should be conf/chukwa-agents.
> Further, stop-agents should not touch cron, since start-agents doesn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5147) remove refs to slaves file

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669226#action_12669226 ] 

Hadoop QA commented on HADOOP-5147:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12399096/betterbin.patch
  against trunk revision 739416.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3782/console

This message is automatically generated.

> remove refs to slaves file
> --------------------------
>
>                 Key: HADOOP-5147
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5147
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>         Attachments: betterbin.patch
>
>
> The Chukwa bin scripts refer to conf/slaves.  This should be conf/chukwa-agents.
> Further, stop-agents should not touch cron, since start-agents doesn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5147) remove refs to slaves file

Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ari Rabkin updated HADOOP-5147:
-------------------------------

    Attachment: betterbin.patch

no tests for bin scripts

> remove refs to slaves file
> --------------------------
>
>                 Key: HADOOP-5147
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5147
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>            Reporter: Ari Rabkin
>            Priority: Minor
>         Attachments: betterbin.patch
>
>
> The Chukwa bin scripts refer to conf/slaves.  This should be conf/chukwa-agents.
> Further, stop-agents should not touch cron, since start-agents doesn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.