You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/21 18:45:00 UTC

[jira] [Commented] (GEODE-2936) Refactor OrderByComparator's compare method to reduce redundant code

    [ https://issues.apache.org/jira/browse/GEODE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096688#comment-16096688 ] 

ASF GitHub Bot commented on GEODE-2936:
---------------------------------------

Github user YehEmily commented on the issue:

    https://github.com/apache/geode/pull/580
  
    @jhuynh1 Thanks for the suggestion! I updated the tests in `OrderByComparatorJUnitTest.java` to cover all the cases in `OrderByComparator.java` and updated the PR.


> Refactor OrderByComparator's compare method to reduce redundant code
> --------------------------------------------------------------------
>
>                 Key: GEODE-2936
>                 URL: https://issues.apache.org/jira/browse/GEODE-2936
>             Project: Geode
>          Issue Type: Bug
>          Components: querying
>            Reporter: nabarun
>            Assignee: Emily Yeh
>
> Issue:
> OrderByComparator's compare method has a lot of redundant code.
> Solution:
> These code sections can be modified to have one method call



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)