[GitHub] [incubator-echarts] 100pah commented on a change in pull request #11479: fix(time): bar bandWidth with time axis #11145

[GitBox <gi...@apache.org>]

100pah commented on a change in pull request #11479: fix(time): bar bandWidth with time axis #11145
URL: https://github.com/apache/incubator-echarts/pull/11479#discussion_r339613636
 
 

 ##########
 File path: src/layout/barGrid.js
 ##########
 @@ -87,16 +87,95 @@ export function prepareLayoutBarSeries(seriesType, ecModel) {
     return seriesModels;
 }
 
+
+/**
+ * Map from axis.index to min gap of two adjacent values.
+ * This works for time axes, value axes, and log axes.
+ * For a single time axis, return value is in the form like
+ * [[1000000]].
+ * The value of 1000000 is in milliseconds.
+ */
+function getValueAxesMinGaps(barSeries) {
+    /**
+     * Map from axis.index to values.
+     * For a single time axis, axisValues is in the form like
+     * [[1495555200000, 1495641600000, 1495728000000]].
+     * Items in axisValues[x], e.g. 1495555200000, are time values of all
+     * series.
+     */
+    var axisValues = [];
 
 Review comment:
   Axes are only indexed by `index` in `axisValues`.
   But if two axes are in different cartesian, the result would be incorrect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org