You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/21 19:40:05 UTC
[GitHub] [kafka] vvcephei commented on issue #8254: KIP-557: Add Emit On Change Support
vvcephei commented on issue #8254:
URL: https://github.com/apache/kafka/pull/8254#issuecomment-617372772
Hey @ConcurrencyPractitioner , sorry it took so long. It's just again because the test happened to expect idempotent updates to flow through regularly, but not for anything important. Just changing the value of the "tick" record the second time fixes it without breaking anything about the test.
Here's my diff:
```diff
--- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SuppressScenarioTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SuppressScenarioTest.java
@@ -615,11 +615,11 @@ public class SuppressScenarioTest {
);
- inputTopicRight.pipeInput("tick", "tick", 21L);
+ inputTopicRight.pipeInput("tick", "tick1", 21L);
verify(
drainProducerRecords(driver, "output", STRING_DESERIALIZER, STRING_DESERIALIZER),
asList(
- new KeyValueTimestamp<>("tick", "(null,tick)", 21), // just a testing artifact
+ new KeyValueTimestamp<>("tick", "(null,tick1)", 21), // just a testing artifact
new KeyValueTimestamp<>("A", "(b,2)", 13L)
)
);
@@ -703,11 +703,11 @@ public class SuppressScenarioTest {
);
- inputTopicLeft.pipeInput("tick", "tick", 21L);
+ inputTopicLeft.pipeInput("tick", "tick1", 21L);
verify(
drainProducerRecords(driver, "output", STRING_DESERIALIZER, STRING_DESERIALIZER),
asList(
- new KeyValueTimestamp<>("tick", "(tick,null)", 21), // just a testing artifact
+ new KeyValueTimestamp<>("tick", "(tick1,null)", 21), // just a testing artifact
new KeyValueTimestamp<>("A", "(2,b)", 13L)
)
);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org