You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "ErikBPF (via GitHub)" <gi...@apache.org> on 2026/09/22 00:36:09 UTC
[PR] ci: drop non-existent suites from the Linux and macOS test matrices [datafusion-comet]
ErikBPF opened a new pull request, #6099:
URL: https://github.com/apache/datafusion-comet/pull/6099
## Which issue does this PR close?
None. Small CI-hygiene follow-up; no tracking issue.
## Rationale for this change
`dev/ci/check-suites.py` only verified that every suite in the source tree is
listed in a workflow. It never verified the reverse, so six suite names that no
longer exist remained in the `linux-test` and macOS matrices:
- `org.apache.comet.CometExpressionCoverageSuite`
- `org.apache.comet.exec.CometAsyncShuffleSuite`
- `org.apache.comet.exec.DisableAQECometAsyncShuffleSuite`
- `org.apache.comet.parquet.ParquetReadV2Suite` (removed in #3671)
- `org.apache.spark.sql.comet.ParquetDatetimeRebaseV1Suite`
- `org.apache.spark.sql.comet.ParquetDatetimeRebaseV2Suite`
CI is green only because the suites are passed via `-DwildcardSuites`, which
ignores unmatched names; an explicit `-Dsuites` list fails with
`ClassNotFoundException`. The matrices therefore claim coverage that does not
run, and nothing prevented a stale name from being re-added.
## What changes are included in this PR?
- Add a forward declaration check to `dev/ci/check-suites.py`: a suite listed in
a workflow must be declared as a `class`/`trait`/`object` in some sourceset.
- Remove the six dead suite lines from `.github/workflows/pr_build_linux.yml`
and `.github/workflows/pr_build_macos.yml`.
`ParquetReadV1Suite` and `CometStringDecodeSuite` stay listed: the former is
declared in `ParquetReadSuite.scala`, the latter in the `spark-3.x` sourceset
used by the 3.4/3.5 profiles.
## How are these changes tested?
- `python3 dev/ci/check-suites.py` reports the six undeclared names (RED) before
the removal, then prints `All workflow-listed suites are declared` and exits 0
after it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: drop non-existent suites from the Linux and macOS test matrices [datafusion-comet]
Posted by "ErikBPF (via GitHub)" <gi...@apache.org>.
ErikBPF commented on PR #6099:
URL: https://github.com/apache/datafusion-comet/pull/6099#issuecomment-5951379885
Updated against pinned main `63fd1c9e`. Rebase conflicts were resolved while retaining upstream matrix additions and `CometUnboundedShuffleMemoryAllocatorSuite`. Published ancestry is retained with an identical-tree merge, without force-pushing.
The reverse suite-declaration check remains: explicitly named matrix suites must resolve to real Scala suite declarations. Stale entries were removed from both Linux and macOS matrices; `ParquetEncryptionITCase` remains covered. There are 151 matrix entries per workflow, not 151 distinct Scala suites.
Verification on Apollo:
- The original stale matrices produced 12 expected diagnostics; corrected matrices passed.
- Deliberately invalid suite names produced the expected two diagnostics.
- CI configuration, syntax, diff checks and workflow-only actionlint passed; independent source review found no introduced defect.
Full actionlint still reports unchanged ShellCheck findings in unedited shell fragments (`SC2006`, `SC2086`, `SC2129`); it is not being reported as fully green. No Scala/runtime change was made in this PR.
Updated head: `81a7b21b53d1be6a81244a8b8bb278d91f6e3c2a` (tested tree unchanged from `cb525947eeef4e3c13bacca9a0446a1607ef0bf4`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: drop non-existent suites from the Linux and macOS test matrices [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #6099:
URL: https://github.com/apache/datafusion-comet/pull/6099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org