You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/06/18 22:52:49 UTC
Review Request 35621: Fixing option type in observer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35621/
-----------------------------------------------------------
Review request for Aurora and Brian Wickman.
Bugs: AURORA-1356
https://issues.apache.org/jira/browse/AURORA-1356
Repository: aurora
Description
-------
Typing is hard in python...
Diffs
-----
src/main/python/apache/aurora/tools/thermos_observer.py d88c03f886244302664cc0d3f2225c94fb913f68
Diff: https://reviews.apache.org/r/35621/diff/
Testing
-------
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 35621: Fixing option type in observer.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35621/#review88448
-----------------------------------------------------------
This patch does not apply cleanly on master (e271634), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 18, 2015, 8:52 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35621/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 8:52 p.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Bugs: AURORA-1356
> https://issues.apache.org/jira/browse/AURORA-1356
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Typing is hard in python...
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/thermos_observer.py d88c03f886244302664cc0d3f2225c94fb913f68
>
> Diff: https://reviews.apache.org/r/35621/diff/
>
>
> Testing
> -------
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35621: Fixing option type in observer.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35621/#review88435
-----------------------------------------------------------
Ship it!
:facepalm:
- Brian Wickman
On June 18, 2015, 8:52 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35621/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 8:52 p.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Bugs: AURORA-1356
> https://issues.apache.org/jira/browse/AURORA-1356
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Typing is hard in python...
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/thermos_observer.py d88c03f886244302664cc0d3f2225c94fb913f68
>
> Diff: https://reviews.apache.org/r/35621/diff/
>
>
> Testing
> -------
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>