[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34062: [SPARK-36819][SQL] Don't insert redundant filters in case static partition pruning can be done

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #34062:
URL: https://github.com/apache/spark/pull/34062#discussion_r713384677



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
##########
@@ -1543,6 +1543,70 @@ abstract class DynamicPartitionPruningSuiteBase
       checkAnswer(df, Row(1150, 1) :: Row(1130, 4) :: Row(1140, 4) :: Nil)
     }
   }
+
+  test("No dynamic partition pruning filters in case of static partition filtering") {

Review comment:
       Could you add `SPARK-36819:` prefix to the test case name?
   ```
   - test("No dynamic partition pruning filters in case of static partition filtering") {
   + test("SPARK-36819: No dynamic partition pruning filters in case of static partition filtering") {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org