You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by dsbos <gi...@git.apache.org> on 2015/09/14 23:21:58 UTC
[GitHub] drill pull request: DRILL-3778: Add missed part of DRILL-3160 (mak...
GitHub user dsbos opened a pull request:
https://github.com/apache/drill/pull/158
DRILL-3778: Add missed part of DRILL-3160 (making JDBC Javadoc available).
Main:
Configured Javadoc generation (title, package groups, version in headers).
Added link to JDBC page in Drill documentation site.
Edited/fixed some JDBC Javadoc comments.
Added explicit SQLConversionOverflowException to throws clauses for Javadoc
effect.
Added some imports for Javadoc references.
Misc.:
Fixed a couple Javadoc syntax errors.
Fixed POM indentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsbos/incubator-drill bugs/drill-3778_DRILL-3160_missed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/158.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #158
----
commit 24226aebf6274806e8d1a355f4c6b83dedee2e83
Author: dbarclay <db...@maprtech.com>
Date: 2015-09-14T17:54:34Z
DRILL-3778: Add missed part of DRILL-3160 (making JDBC Javadoc available).
Main:
Configured Javadoc generation (title, package groups, version in headers).
Added link to JDBC page in Drill documentation site.
Edited/fixed some JDBC Javadoc comments.
Added explicit SQLConversionOverflowException to throws clauses for Javadoc
effect.
Added some imports for Javadoc references.
Misc.:
Fixed a couple Javadoc syntax errors.
Fixed POM indentation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3778: Add missed part of DRILL-3160 (mak...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/158#discussion_r40260917
--- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/package-info.java ---
@@ -19,7 +19,13 @@
/**
* JDBC driver for Drill.
* <p>
- * Drill's JDBC driver class is {@link org.apache.drill.jdbc.Driver}.
+ * Drill's JDBC driver class is
+ * {@link org.apache.drill.jdbc.Driver org.apache.drill.jdbc.Driver}.
--- End diff --
Sounds good, just making sure it wasn't a mistake. I'll be merging shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3778: Add missed part of DRILL-3160 (mak...
Posted by dsbos <gi...@git.apache.org>.
Github user dsbos commented on the pull request:
https://github.com/apache/drill/pull/158#issuecomment-142729309
@jaltekruse, can you review and merge this commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3778: Add missed part of DRILL-3160 (mak...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/158#discussion_r40260046
--- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/package-info.java ---
@@ -19,7 +19,13 @@
/**
* JDBC driver for Drill.
* <p>
- * Drill's JDBC driver class is {@link org.apache.drill.jdbc.Driver}.
+ * Drill's JDBC driver class is
+ * {@link org.apache.drill.jdbc.Driver org.apache.drill.jdbc.Driver}.
--- End diff --
Is this link tag written like this because you want the fully qualified name to be shown as the link text?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3778: Add missed part of DRILL-3160 (mak...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3778: Add missed part of DRILL-3160 (mak...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/158#issuecomment-142735217
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3778: Add missed part of DRILL-3160 (mak...
Posted by dsbos <gi...@git.apache.org>.
Github user dsbos commented on a diff in the pull request:
https://github.com/apache/drill/pull/158#discussion_r40260511
--- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/package-info.java ---
@@ -19,7 +19,13 @@
/**
* JDBC driver for Drill.
* <p>
- * Drill's JDBC driver class is {@link org.apache.drill.jdbc.Driver}.
+ * Drill's JDBC driver class is
+ * {@link org.apache.drill.jdbc.Driver org.apache.drill.jdbc.Driver}.
--- End diff --
Yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---