[jira] [Commented] (MINIFICPP-336) With default GetFile settings dot files are not getting ignored on linux systems as they should

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322676#comment-16322676 ] 

ASF GitHub Bot commented on MINIFICPP-336:
------------------------------------------

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/238

    MINIFICPP-336: Use correct path when excluding dot files

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-336

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #238
    
----
commit 0b813a95af19e2db3d0c809d43c4c057f1b49e0c
Author: Marc Parisi <ph...@...>
Date:   2018-01-11T18:02:24Z

    MINIFICPP-336: Use correct path when excluding dot files

----


> With default GetFile settings dot files are not getting ignored on linux systems as they should
> -----------------------------------------------------------------------------------------------
>
>                 Key: MINIFICPP-336
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-336
>             Project: NiFi MiNiFi C++
>          Issue Type: Bug
>    Affects Versions: 0.1.0, 0.2.0, 0.3.0
>            Reporter: Joseph Witt
>            Assignee: marco polo
>             Fix For: 0.4.0
>
>
> With this config
> Processors:
> - name: GetFile
>   class: org.apache.nifi.processors.standard.GetFile
>   max concurrent tasks: 1
>   scheduling strategy: TIMER_DRIVEN
>   scheduling period: 0 sec
>   penalization period: 30 sec
>   yield period: 1 sec
>   run duration nanos: 0
>   auto-terminated relationships list: []
>   Properties:
>     Batch Size: '10'
>     File Filter: '[^\.].*'
>     Ignore Hidden Files: 'true'
>     Input Directory: test/input
>     Keep Source File: 'false'
>     Maximum File Age:
>     Maximum File Size:
>     Minimum File Age: 0 sec
>     Minimum File Size: 0 B
>     Path Filter:
>     Polling Interval: 0 sec
>     Recurse Subdirectories: 'true'
> The minifi flow picks up any files starting with '.' character right away.  I believe this is causing duplication to occur when NiFi writes to that directory being watched, for example, because it writes the files a hidden/dot notation then renamed it when done.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)