[jira] [Commented] (SOLR-14256) Remove HashDocSet

["David Smiley (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061187#comment-17061187 ] 

David Smiley commented on SOLR-14256:
-------------------------------------

There's a PR to fix [https://github.com/apache/lucene-solr/pull/1358|https://github.com/apache/lucene-solr/pull/1358] -- I could use a review!

> Remove HashDocSet
> -----------------
>
>                 Key: SOLR-14256
>                 URL: https://issues.apache.org/jira/browse/SOLR-14256
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: search
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>             Fix For: master (9.0)
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This particular DocSet is only used in places where we need to convert SortedIntDocSet in particular to a DocSet that is fast for random access.  Once such a conversion happens, it's only used to test some docs for presence and it could be another interface.  DocSet has kind of a large-ish API surface area to implement.  Since we only need to test docs, we could use Bits interface (having only 2 methods) backed by an off-the-shelf primitive long hash set on our classpath.  Perhaps a new method on DocSet: getBits() or DocSetUtil.getBits(DocSet).
> In addition to removing complexity unto itself, this improvement is required by SOLR-14185 because it wants to be able to produce a DocIdSetIterator slice directly from the DocSet but HashDocSet can't do that without sorting first.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org