You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/06/01 20:40:46 UTC

[GitHub] reddycharan commented on issue #1460: Metrics for EntryLogManagerForEntryLogPerLedger.

reddycharan commented on issue #1460: Metrics for EntryLogManagerForEntryLogPerLedger.
URL: https://github.com/apache/bookkeeper/pull/1460#issuecomment-394003173
 
 
   Hey @sijie 
   
   > I think you might need to merge to latest master for some checkstyle issues
   
   I ran "mvn clean apache-rat:check install spotbugs:check -DskipTests" locally, before and after rebasing to latest master and i see no issues. So not sure what is causing problem here.
   
   > bump the commons-lang3 requires updating the LICENSE files
   
   didn't know about it, will follow previous examples. BTW I need to update version of apache.commons.lang3 because APIs like incrementAndGet of MutableInt are added in version 3.5 https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/mutable/MutableInt.html#incrementAndGet--
   
   > bump the commons-lang3 seems introduce some deprecation warnings
   
   not sure what you are referring to and what should I do about it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services