[GitHub] [shardingsphere] gxxiong commented on a diff in pull request #22557: Ignore license header for ShardingSphereDriverURL.toConfigurationBytes()

[GitBox <gi...@apache.org>]

gxxiong commented on code in PR #22557:
URL: https://github.com/apache/shardingsphere/pull/22557#discussion_r1036803081


##########
jdbc/core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/driver/ShardingSphereDriverURL.java:
##########
@@ -57,7 +62,25 @@ public ShardingSphereDriverURL(final String url) {
     @SneakyThrows(IOException.class)
     public byte[] toConfigurationBytes() {
         try (InputStream stream = inClasspath ? ShardingSphereDriverURL.class.getResourceAsStream("/" + file) : Files.newInputStream(new File(file).toPath())) {
-            byte[] result = new byte[null == stream ? 0 : stream.available()];
+            LineProcessor<byte[]> lineProcessor = new LineProcessor<byte[]>() {
+                
+                private final StringBuilder builder = new StringBuilder();
+                

Review Comment:
   File reading will have problems when packaged into jar



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org