[GitHub] [incubator-doris] wangbo commented on issue #1816: v2 segment support string encode(#1766)

[GitBox <gi...@apache.org>]

wangbo commented on issue #1816: v2 segment support string encode(#1766)
URL: https://github.com/apache/incubator-doris/pull/1816#issuecomment-536375079
 
 
   > I have check set_to_max in olap, I think original code has bug and this pr's code has fix it.
   > I check set_to_max used in two place of v1:
   > 
   > 1. in zone map building. But for char/varchar type, there are no zone map for them, so there is no influence.
   > 2. in split_range for query, I think the new max is larger than the old one, will not cause problems.
   >    LGTM
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org