You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/07 16:09:55 UTC
[GitHub] [incubator-superset] rubenSastre opened a new pull request #11187: button translations missing
rubenSastre opened a new pull request #11187:
URL: https://github.com/apache/incubator-superset/pull/11187
### SUMMARY
translation missing on some buttons
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11187: fix: button translations missing
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11187:
URL: https://github.com/apache/incubator-superset/pull/11187#issuecomment-705052670
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=h1) Report
> Merging [#11187](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6e0d1b840983df65eb10fa9ef89fbc0b1430d10b?el=desc) will **decrease** coverage by `5.53%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11187 +/- ##
==========================================
- Coverage 65.80% 60.27% -5.54%
==========================================
Files 828 392 -436
Lines 39121 24558 -14563
Branches 3693 0 -3693
==========================================
- Hits 25745 14803 -10942
+ Misses 13269 9755 -3514
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.27% <ø> (-0.90%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=footer). Last update [6e0d1b8...cc21229](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rubenSastre commented on pull request #11187: fix: button translations missing
Posted by GitBox <gi...@apache.org>.
rubenSastre commented on pull request #11187:
URL: https://github.com/apache/incubator-superset/pull/11187#issuecomment-709181376
pull is validated, can someone merge it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11187: fix: button translations missing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11187:
URL: https://github.com/apache/incubator-superset/pull/11187#issuecomment-705052670
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=h1) Report
> Merging [#11187](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6e0d1b840983df65eb10fa9ef89fbc0b1430d10b?el=desc) will **decrease** coverage by `5.46%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11187 +/- ##
==========================================
- Coverage 65.80% 60.34% -5.47%
==========================================
Files 828 392 -436
Lines 39121 24558 -14563
Branches 3693 0 -3693
==========================================
- Hits 25745 14820 -10925
+ Misses 13269 9738 -3531
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.34% <ø> (-0.83%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (-0.83%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.38% <0.00%> (-0.53%)` | :arrow_down: |
| ... and [444 more](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=footer). Last update [6e0d1b8...cc21229](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11187: fix: button translations missing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11187:
URL: https://github.com/apache/incubator-superset/pull/11187#issuecomment-705052670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11187: fix: button translations missing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11187:
URL: https://github.com/apache/incubator-superset/pull/11187#issuecomment-705052670
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=h1) Report
> Merging [#11187](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6e0d1b840983df65eb10fa9ef89fbc0b1430d10b?el=desc) will **decrease** coverage by `10.74%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11187 +/- ##
===========================================
- Coverage 65.80% 55.06% -10.75%
===========================================
Files 828 402 -426
Lines 39121 13338 -25783
Branches 3693 3389 -304
===========================================
- Hits 25745 7345 -18400
+ Misses 13269 5801 -7468
- Partials 107 192 +85
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.06% <ø> (-0.94%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | | |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | | |
| [...perset-frontend/src/messageToasts/actions/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC5qcw==) | | |
| [superset/utils/schema.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NoZW1hLnB5) | | |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | | |
| [superset/migrations/versions/c9495751e314\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jOTQ5NTc1MWUzMTRfLnB5) | | |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | | |
| [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | | |
| [superset/migrations/versions/d6db5a5cdb5d\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kNmRiNWE1Y2RiNWRfLnB5) | | |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | | |
| ... and [1216 more](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=footer). Last update [6e0d1b8...d49b196](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11187: fix: button translations missing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11187:
URL: https://github.com/apache/incubator-superset/pull/11187#issuecomment-705052670
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=h1) Report
> Merging [#11187](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6e0d1b840983df65eb10fa9ef89fbc0b1430d10b?el=desc) will **decrease** coverage by `10.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11187 +/- ##
===========================================
- Coverage 65.80% 55.77% -10.04%
===========================================
Files 828 402 -426
Lines 39121 13338 -25783
Branches 3693 3389 -304
===========================================
- Hits 25745 7439 -18306
+ Misses 13269 5712 -7557
- Partials 107 187 +80
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.77% <ø> (-0.23%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/energy.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | | |
| [.../migrations/versions/d827694c7555\_css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kODI3Njk0Yzc1NTVfY3NzX3RlbXBsYXRlcy5weQ==) | | |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | | |
| [...tions/versions/3b626e2a6783\_sync\_db\_with\_models.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zYjYyNmUyYTY3ODNfc3luY19kYl93aXRoX21vZGVscy5weQ==) | | |
| [...tions/versions/1a48a5411020\_adding\_slug\_to\_dash.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xYTQ4YTU0MTEwMjBfYWRkaW5nX3NsdWdfdG9fZGFzaC5weQ==) | | |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | | |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | | |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | | |
| [...hboard/util/getChartAndLabelComponentIdFromPath.js](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENoYXJ0QW5kTGFiZWxDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | | |
| ... and [1216 more](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=footer). Last update [6e0d1b8...d49b196](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #11187: fix: button translations missing
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #11187:
URL: https://github.com/apache/incubator-superset/pull/11187
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11187: fix: button translations missing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11187:
URL: https://github.com/apache/incubator-superset/pull/11187#issuecomment-705052670
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=h1) Report
> Merging [#11187](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6e0d1b840983df65eb10fa9ef89fbc0b1430d10b?el=desc) will **decrease** coverage by `7.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11187 +/- ##
==========================================
- Coverage 65.80% 58.80% -7.01%
==========================================
Files 828 795 -33
Lines 39121 37920 -1201
Branches 3693 3429 -264
==========================================
- Hits 25745 22298 -3447
- Misses 13269 15438 +2169
- Partials 107 184 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.96% <100.00%> (-0.04%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `60.34% <ø> (-0.83%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ntend/src/dashboard/components/PublishedStatus.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy5qc3g=) | `61.90% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `91.66% <ø> (ø)` | |
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `93.93% <100.00%> (-0.73%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| ... and [276 more](https://codecov.io/gh/apache/incubator-superset/pull/11187/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=footer). Last update [6e0d1b8...cc21229](https://codecov.io/gh/apache/incubator-superset/pull/11187?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org