[GitHub] flink pull request #2550: [FLINK-4657] Implement HighAvailabilityServices ba...

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2550#discussion_r80733924
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java ---
    @@ -467,6 +487,128 @@ public void registerAtResourceManager(final String address) {
     		//TODO:: register at the RM
     	}
     
    +	@RpcMethod
    +	public NextInputSplit requestNextInputSplit(final JobVertexID vertexID, final ExecutionAttemptID executionAttempt) {
    +		final byte[] serializedInputSplit;
    +
    +		final Execution execution = executionGraph.getRegisteredExecutions().get(executionAttempt);
    +		if (execution == null) {
    +			log.error("Can not find Execution for attempt {}.", executionAttempt);
    --- End diff --
    
    The log could be on "debug" level, as this situation can occur when the JobManager failed tasks and unregistered them, but the cancel() messages have not reached the TaskManager.
    
    Since this is a valid situation, it should not cause a "WARN" message. In general, all situations that are valid race conditions and that need not indicate a corrupted state or lead to a failure / recovery should probably not have a "WARN" level.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---