You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/14 05:35:13 UTC

[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #5824: Spark: support hilbert curve when rewrite

ajantha-bhat commented on code in PR #5824:
URL: https://github.com/apache/iceberg/pull/5824#discussion_r1021091018


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/SparkSpaceCurveStrategy.java:
##########
@@ -57,8 +57,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class SparkZOrderStrategy extends SparkSortStrategy {

Review Comment:
   Maybe we cannot rename the public interfaces. It may break compatibility.
   We need to deprecate first and provide an alternate implementation. Later remove the deprecated class in the next version.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org