You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/04/09 22:13:04 UTC

Review Request 66517: [ATLAS-2550]: On deleting entity with classification , classification is removed from the entity, but search on classification lists the entity

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66517/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2550
    https://issues.apache.org/jira/browse/ATLAS-2550


Repository: atlas


Description
-------

1.Created an hive_table and added classification to it.
2.Dropped the hive_table.

The classification is removed from the hive_table entity. Entity response of hive_table doesn't have the classification. But search on that classification still returns the entity.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 6386bcb7 


Diff: https://reviews.apache.org/r/66517/diff/1/


Testing
-------

Validated that the search (basic/advanced) on classification on deleted entity is not retrieved.


Thanks,

Sarath Subramanian


Re: Review Request 66517: [ATLAS-2550]: On deleting entity with classification , classification is removed from the entity, but search on classification lists the entity

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66517/#review200770
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On April 9, 2018, 10:13 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66517/
> -----------------------------------------------------------
> 
> (Updated April 9, 2018, 10:13 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2550
>     https://issues.apache.org/jira/browse/ATLAS-2550
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> 1.Created an hive_table and added classification to it.
> 2.Dropped the hive_table.
> 
> The classification is removed from the hive_table entity. Entity response of hive_table doesn't have the classification. But search on that classification still returns the entity.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 6386bcb7 
> 
> 
> Diff: https://reviews.apache.org/r/66517/diff/1/
> 
> 
> Testing
> -------
> 
> Validated that the search (basic/advanced) on classification on deleted entity is not retrieved.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Re: Review Request 66517: [ATLAS-2550]: On deleting entity with classification , classification is removed from the entity, but search on classification lists the entity

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66517/#review200771
-----------------------------------------------------------


Ship it!




Ship It!

- Ashutosh Mestry


On April 9, 2018, 10:13 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66517/
> -----------------------------------------------------------
> 
> (Updated April 9, 2018, 10:13 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2550
>     https://issues.apache.org/jira/browse/ATLAS-2550
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> 1.Created an hive_table and added classification to it.
> 2.Dropped the hive_table.
> 
> The classification is removed from the hive_table entity. Entity response of hive_table doesn't have the classification. But search on that classification still returns the entity.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 6386bcb7 
> 
> 
> Diff: https://reviews.apache.org/r/66517/diff/1/
> 
> 
> Testing
> -------
> 
> Validated that the search (basic/advanced) on classification on deleted entity is not retrieved.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>