[GitHub] [phoenix] virajjasani commented on a change in pull request #960: PHOENIX-6155 : Provide a coprocessor endpoint to avoid direct upserts into SYSTEM.TASK from the client

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #960:
URL: https://github.com/apache/phoenix/pull/960#discussion_r521329651



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -1094,6 +1095,11 @@ private void addCoprocessors(byte[] tableName, TableDescriptorBuilder builder,
                 if(!newDesc.hasCoprocessor(TaskRegionObserver.class.getName())) {
                     builder.addCoprocessor(TaskRegionObserver.class.getName(), null, priority, null);
                 }
+                if (!newDesc.hasCoprocessor(

Review comment:
       Yes, we would need to take care of upgrade path. Updated PR with changes in `upgradeSystemTask()` function by handling addition of this new coprocessor, test is available in `BackwardCompatibilityIT` for existence of new coprocessor in updated table descriptor.
   Thanks for the suggestion @ChinmaySKulkarni 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org