You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by "niki.lj" <ni...@aliyun.com.INVALID> on 2019/06/14 03:25:31 UTC
[Disscuss][Java] Add more check style rule for Java code
Hi all,
We recently discovered that style check rules for Java code could be enhanced, for example, "unused imports" and "redundant modifier" checks are not included before.
I created ARROW-5587 and submitted a PR (https://github.com/apache/arrow/pull/4567) for this, and open this thread according to the comments of @Micah Kornfield.
If you have any different ideas, please let me know. Thanks!
Best,
Ji Liu
Re: [Disscuss][Java] Add more check style rule for Java code
Posted by Micah Kornfield <em...@gmail.com>.
Hi Jonathan,
I think you need to e-mail dev-unsubcribe@arrow.apache.org to unsubscribe.
Thanks,
Micah
On Sun, Jun 23, 2019 at 6:42 PM Jonathan Spooner <js...@gmail.com> wrote:
> Unsubscribe
>
> On Thu, Jun 13, 2019 at 9:21 PM Micah Kornfield <em...@gmail.com>
> wrote:
>
>> I'm in favor of the changes also, but since they affect the entire Java
>> codebase I wanted people to be aware of them in case there are any
>> objections. I plan to merge the PR tomorrow evening Past or over the
>> weekend unless someone voices an objection.
>>
>> Thanks,
>> Micah
>>
>> On Thursday, June 13, 2019, Fan Liya <li...@gmail.com> wrote:
>>
>> > +1 for removing unused imports
>> >
>> > On Fri, Jun 14, 2019 at 11:25 AM niki.lj <ni...@aliyun.com.invalid>
>> > wrote:
>> >
>> >> Hi all,
>> >> We recently discovered that style check rules for Java code could be
>> >> enhanced, for example, "unused imports" and "redundant modifier"
>> checks are
>> >> not included before.
>> >> I created ARROW-5587 and submitted a PR (https://github.com/apache/
>> >> arrow/pull/4567) for this, and open this thread according to the
>> >> comments of @Micah Kornfield.
>> >> If you have any different ideas, please let me know. Thanks!
>> >>
>> >> Best,
>> >> Ji Liu
>> >>
>> >>
>>
>
Re: [Disscuss][Java] Add more check style rule for Java code
Posted by Jonathan Spooner <js...@gmail.com>.
Unsubscribe
On Thu, Jun 13, 2019 at 9:21 PM Micah Kornfield <em...@gmail.com>
wrote:
> I'm in favor of the changes also, but since they affect the entire Java
> codebase I wanted people to be aware of them in case there are any
> objections. I plan to merge the PR tomorrow evening Past or over the
> weekend unless someone voices an objection.
>
> Thanks,
> Micah
>
> On Thursday, June 13, 2019, Fan Liya <li...@gmail.com> wrote:
>
> > +1 for removing unused imports
> >
> > On Fri, Jun 14, 2019 at 11:25 AM niki.lj <ni...@aliyun.com.invalid>
> > wrote:
> >
> >> Hi all,
> >> We recently discovered that style check rules for Java code could be
> >> enhanced, for example, "unused imports" and "redundant modifier" checks
> are
> >> not included before.
> >> I created ARROW-5587 and submitted a PR (https://github.com/apache/
> >> arrow/pull/4567) for this, and open this thread according to the
> >> comments of @Micah Kornfield.
> >> If you have any different ideas, please let me know. Thanks!
> >>
> >> Best,
> >> Ji Liu
> >>
> >>
>
Re: [Disscuss][Java] Add more check style rule for Java code
Posted by Praveen Kumar <pr...@dremio.com>.
Sounds good Micah.
On Fri, Jun 14, 2019 at 11:08 AM Ravindra Pindikura <ra...@dremio.com>
wrote:
> +1
>
> On Fri, Jun 14, 2019 at 9:51 AM Micah Kornfield <em...@gmail.com>
> wrote:
>
> > I'm in favor of the changes also, but since they affect the entire Java
> > codebase I wanted people to be aware of them in case there are any
> > objections. I plan to merge the PR tomorrow evening Past or over the
> > weekend unless someone voices an objection.
> >
> > Thanks,
> > Micah
> >
> > On Thursday, June 13, 2019, Fan Liya <li...@gmail.com> wrote:
> >
> > > +1 for removing unused imports
> > >
> > > On Fri, Jun 14, 2019 at 11:25 AM niki.lj <ni...@aliyun.com.invalid>
> > > wrote:
> > >
> > >> Hi all,
> > >> We recently discovered that style check rules for Java code could be
> > >> enhanced, for example, "unused imports" and "redundant modifier"
> checks
> > are
> > >> not included before.
> > >> I created ARROW-5587 and submitted a PR (https://github.com/apache/
> > >> arrow/pull/4567) for this, and open this thread according to the
> > >> comments of @Micah Kornfield.
> > >> If you have any different ideas, please let me know. Thanks!
> > >>
> > >> Best,
> > >> Ji Liu
> > >>
> > >>
> >
>
>
> --
> Thanks and regards,
> Ravindra.
>
Re: [Disscuss][Java] Add more check style rule for Java code
Posted by Ravindra Pindikura <ra...@dremio.com>.
+1
On Fri, Jun 14, 2019 at 9:51 AM Micah Kornfield <em...@gmail.com>
wrote:
> I'm in favor of the changes also, but since they affect the entire Java
> codebase I wanted people to be aware of them in case there are any
> objections. I plan to merge the PR tomorrow evening Past or over the
> weekend unless someone voices an objection.
>
> Thanks,
> Micah
>
> On Thursday, June 13, 2019, Fan Liya <li...@gmail.com> wrote:
>
> > +1 for removing unused imports
> >
> > On Fri, Jun 14, 2019 at 11:25 AM niki.lj <ni...@aliyun.com.invalid>
> > wrote:
> >
> >> Hi all,
> >> We recently discovered that style check rules for Java code could be
> >> enhanced, for example, "unused imports" and "redundant modifier" checks
> are
> >> not included before.
> >> I created ARROW-5587 and submitted a PR (https://github.com/apache/
> >> arrow/pull/4567) for this, and open this thread according to the
> >> comments of @Micah Kornfield.
> >> If you have any different ideas, please let me know. Thanks!
> >>
> >> Best,
> >> Ji Liu
> >>
> >>
>
--
Thanks and regards,
Ravindra.
Re: [Disscuss][Java] Add more check style rule for Java code
Posted by Micah Kornfield <em...@gmail.com>.
I'm in favor of the changes also, but since they affect the entire Java
codebase I wanted people to be aware of them in case there are any
objections. I plan to merge the PR tomorrow evening Past or over the
weekend unless someone voices an objection.
Thanks,
Micah
On Thursday, June 13, 2019, Fan Liya <li...@gmail.com> wrote:
> +1 for removing unused imports
>
> On Fri, Jun 14, 2019 at 11:25 AM niki.lj <ni...@aliyun.com.invalid>
> wrote:
>
>> Hi all,
>> We recently discovered that style check rules for Java code could be
>> enhanced, for example, "unused imports" and "redundant modifier" checks are
>> not included before.
>> I created ARROW-5587 and submitted a PR (https://github.com/apache/
>> arrow/pull/4567) for this, and open this thread according to the
>> comments of @Micah Kornfield.
>> If you have any different ideas, please let me know. Thanks!
>>
>> Best,
>> Ji Liu
>>
>>
Re: [Disscuss][Java] Add more check style rule for Java code
Posted by Fan Liya <li...@gmail.com>.
+1 for removing unused imports
On Fri, Jun 14, 2019 at 11:25 AM niki.lj <ni...@aliyun.com.invalid> wrote:
> Hi all,
> We recently discovered that style check rules for Java code could be
> enhanced, for example, "unused imports" and "redundant modifier" checks are
> not included before.
> I created ARROW-5587 and submitted a PR (
> https://github.com/apache/arrow/pull/4567) for this, and open this thread
> according to the comments of @Micah Kornfield.
> If you have any different ideas, please let me know. Thanks!
>
> Best,
> Ji Liu
>
>