You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/12 08:29:30 UTC

[GitHub] [arrow] bdunlay edited a comment on pull request #7939: ARROW-9698: [C++] Remove -DNDEBUG flag leak in .pc file

bdunlay edited a comment on pull request #7939:
URL: https://github.com/apache/arrow/pull/7939#issuecomment-672730870


   Actually, given the approach here, it wouldn't need to change -- my change would set a different flag rather than NDEBUG. 
   
   In any case, this change was one approach suggested in the jira issue, but I am happy to change it. 
   
   From the code you pointed out, the NDEBUG check could simply be removed (not sure why it is necessary, if NDEBUG would also disable the assert anyway?). Or, it could be moved inside of the function definition and break/do nothing. 
   
   Thoughts or preferences?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org