[geode] branch develop updated: GEODE-8013: Logging documentation fixes (#4975)

[mk...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mkevo pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new ee60677  GEODE-8013: Logging documentation fixes (#4975)
ee60677 is described below

commit ee606776d2103fbe87c250ac379d35b03a11c5fc
Author: Alberto Bustamante Reyes <al...@users.noreply.github.com>
AuthorDate: Thu Apr 23 08:16:52 2020 +0200

    GEODE-8013: Logging documentation fixes (#4975)
    
    * Logging documentation fixes
    
    * Re-wording after review
    
    * Empty commit to retrigger CI
---
 geode-docs/managing/logging/configuring_log4j2.html.md.erb        | 3 +--
 geode-docs/tools_modules/gfsh/command-pages/change.html.md.erb    | 4 +++-
 .../org/apache/geode/logging/internal/log4j/api/FastLogger.java   | 8 +++++---
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/geode-docs/managing/logging/configuring_log4j2.html.md.erb b/geode-docs/managing/logging/configuring_log4j2.html.md.erb
index 78001e2..4342603 100644
--- a/geode-docs/managing/logging/configuring_log4j2.html.md.erb
+++ b/geode-docs/managing/logging/configuring_log4j2.html.md.erb
@@ -63,5 +63,4 @@ Custom Log4j 2 configuration in <%=vars.product_name%> comes with some caveats a
     ```
 
     You can enable the GEODE\_VERBOSE log statements by changing `onMatch="DENY"` to `onMatch="ACCEPT"`. Typically, it's more useful to simply enable DEBUG or TRACE on certain classes or packages instead of for the entire <%=vars.product_name%> product. However, this setting can be used for internal debugging purposes if all other debugging methods fail.
-
-
+-   The usage of filters can have an impact on performance. <%=vars.product_name%> has some logging optimizations that are deactivated when filters are used (except for the GEODE_VERBOSE marker mentioned previously).
\ No newline at end of file
diff --git a/geode-docs/tools_modules/gfsh/command-pages/change.html.md.erb b/geode-docs/tools_modules/gfsh/command-pages/change.html.md.erb
index 50ad246..806afc0 100644
--- a/geode-docs/tools_modules/gfsh/command-pages/change.html.md.erb
+++ b/geode-docs/tools_modules/gfsh/command-pages/change.html.md.erb
@@ -20,7 +20,9 @@ limitations under the License.
 -->
 <a id="topic_E74ED23CB60342538B2175C326E7D758"></a>
 
-Changes the logging level on specified members.
+Changes the logging level on specified members. This command takes effect if the default <%=vars.product_name%> logging configuration is used.
+
+When using a custom `Log4J` configuration, this command takes effect only if the member whose logging level you want to change was started using the `--J=-Dgeode.LOG_LEVEL_UPDATE_OCCURS=ALWAYS` system property.
 
 **Availability:** Online. You must be connected in `gfsh` to a JMX Manager member to use this command.
 
diff --git a/geode-logging/src/main/java/org/apache/geode/logging/internal/log4j/api/FastLogger.java b/geode-logging/src/main/java/org/apache/geode/logging/internal/log4j/api/FastLogger.java
index f5d771b..ef9bb0a 100644
--- a/geode-logging/src/main/java/org/apache/geode/logging/internal/log4j/api/FastLogger.java
+++ b/geode-logging/src/main/java/org/apache/geode/logging/internal/log4j/api/FastLogger.java
@@ -24,10 +24,12 @@ import org.apache.logging.log4j.status.StatusLogger;
 import org.apache.geode.annotations.internal.MakeNotStatic;
 
 /**
- * Overrides is-enabled checks for log levels below INFO to avoid performance penalties when the log
- * level is INFO or above. If delegating is true then it will always delegate to
- * ExtendedLoggerWrapper for is-enabled checks.
+ * Overrides is-enabled checks to avoid performance penalties in the following cases:
+ * - log level is lower than INFO
+ * - log configuration has filters
  *
+ * If delegating is true then it will always delegate to ExtendedLoggerWrapper for is-enabled
+ * checks.
  */
 public class FastLogger extends ExtendedLoggerWrapper {
   private static final long serialVersionUID = 7084130827962463327L;