[jira] [Commented] (OOZIE-1454) Documentation for cron syntax scheduling of coordinator job

["Robert Kanter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786646#comment-13786646 ] 

Robert Kanter commented on OOZIE-1454:
--------------------------------------

Looks good overall; a few things:
# It would be good to have a few explanatory overview sentences at the beginning of the cron section instead of just starting with the example and the fields.  e.g. "Cron syntax is a standard for specifying time-based schedules.  Using this syntax instead of the previously discussed syntax allows for more complex schedules in coordinator jobs.  For example, you can specify ..." and maybe some more.  Not everyone is familiar with cron or cron syntax.
# You should say what happens if the user specifies something like Jan 35th
# In your example about Tokyo, you should also say what the (incorrect) expression would be.  i.e. "...if you want to run a job on every weekday at 10am in Tokyo, Japan(UTC + 9), your cron expression should be "0 1 * * 2-6", instead of "0 10 * * 2-6", which you might otherwise expect" or something like that
# The stuff explaining the cron syntax looks like it was taken directly from http://quartz-scheduler.org/api/2.1.5/org/quartz/CronExpression.html  I'm no legal expert, but I think you should at least provide a link to that page.
# Perhaps it should mention something about how the cron expressions work with the EL Functions such as {{current(...)}}?
# There are some lines that are longer than 132 characters

> Documentation for cron syntax scheduling of coordinator job
> -----------------------------------------------------------
>
>                 Key: OOZIE-1454
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1454
>             Project: Oozie
>          Issue Type: Sub-task
>            Reporter: Bowen Zhang
>            Assignee: Bowen Zhang
>         Attachments: oozie-1454.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)