You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "Michael Jumper (JIRA)" <ji...@apache.org> on 2016/08/08 20:38:20 UTC
[jira] [Issue Comment Deleted] (GUACAMOLE-33) Duplicate mouse
cursors
[ https://issues.apache.org/jira/browse/GUACAMOLE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Jumper updated GUACAMOLE-33:
------------------------------------
Comment: was deleted
(was: GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/8
GUACAMOLE-33: Fix duplication of mouse cursors
From [GUACAMOLE-33](https://issues.apache.org/jira/browse/GUACAMOLE-33):
> This is caused by the lack of a mechanism to signal `guac_common_cursor` of a leaving user. Such a mechanism used to exist, but was removed when thought unnecessary.
>
> It turns out this is actually necessary, as there is otherwise no guarantee that a newly-allocated user will have a different memory address from the user that just left, and thus certain cursor updates (such as the setting of opacity) may be omitted under the assumption that the user must be the same. *This assumption can fail frequently*, as the memory manager will often service a memory allocation request using a recently-freed memory block.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-server fix-cursor-duplication
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-server/pull/8.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8
----
commit 92e2f4e42074693bdc540ec9d0ae7392c7771a65
Author: Michael Jumper <mj...@apache.org>
Date: 2016-04-19T01:53:12Z
GUACAMOLE-33: Restore guac_common_cursor_remove_user() (reverts commit af7968e).
commit 46b29edc5f64d361a6d190b67425910423a7b3a9
Author: Michael Jumper <mj...@apache.org>
Date: 2016-04-19T01:58:16Z
GUACAMOLE-33: Actually use VNC's leave handler.
commit 82fd6a279b110a7d1cab7a7f3c48c9dfcaecb7e3
Author: Michael Jumper <mj...@apache.org>
Date: 2016-04-19T02:03:38Z
GUACAMOLE-33: Implement leave handlers for RDP, SSH, and telnet.
commit 2b8e1555c68b3eab2b401e506849353d7a04e29e
Author: Michael Jumper <mj...@apache.org>
Date: 2016-04-19T03:07:54Z
GUACAMOLE-33: Fix comment regarding user removal.
----
)
> Duplicate mouse cursors
> -----------------------
>
> Key: GUACAMOLE-33
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-33
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-server
> Reporter: Michael Jumper
> Assignee: Michael Jumper
> Priority: Critical
>
> After joining a connection (any protocol), if the browser tab is reloaded, a duplicate (software) mouse cursor is shown after the connection is reestablished. It does not vanish when the mouse leaves the browser window.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)