You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/11 12:33:31 UTC

[GitHub] [airflow] RyanSiu1995 commented on a change in pull request #18883: Upgrade the graph api to latest veersion

RyanSiu1995 commented on a change in pull request #18883:
URL: https://github.com/apache/airflow/pull/18883#discussion_r726075614



##########
File path: airflow/providers/facebook/ads/hooks/ads.py
##########
@@ -66,7 +66,7 @@ class FacebookAdsReportingHook(BaseHook):
     def __init__(
         self,
         facebook_conn_id: str = default_conn_name,
-        api_version: str = "v6.0",
+        api_version: str = "v12.0",

Review comment:
       Instead of dropping the default value, why not making it as Optional?
   User can still define their own version.
   But the library will fall back to facebook_businss default api version if they don't specifiy it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org