You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/12/06 08:14:31 UTC

[GitHub] [incubator-devlake] klesh commented on a diff in pull request #3861: Feat: jenkins time filter

klesh commented on code in PR #3861:
URL: https://github.com/apache/incubator-devlake/pull/3861#discussion_r1040618532


##########
plugins/helper/api_collector.go:
##########
@@ -283,7 +283,7 @@ func (collector *ApiCollector) fetchPagesUndetermined(reqData *RequestData) {
 					return nil
 				}
 				apiClient.NextTick(func() errors.Error {
-					reqDataCopy.Pager.Skip += collector.args.PageSize
+					reqDataCopy.Pager.Skip += collector.args.PageSize * concurrency

Review Comment:
   Shouldn't it be `* i`?



##########
plugins/jenkins/tasks/stage_collector.go:
##########
@@ -77,7 +81,6 @@ func CollectApiStages(taskCtx core.SubTaskContext) errors.Error {
 			Table: RAW_STAGE_TABLE,
 		},
 		ApiClient:   data.ApiClient,
-		PageSize:    100,

Review Comment:
   So, ApiStages is returning all its items?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org