You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/28 18:18:05 UTC

[GitHub] [arrow] edponce commented on a change in pull request #12014: ARROW-10924: [C++] Validate temporal data in ValidateArrayFull

edponce commented on a change in pull request #12014:
URL: https://github.com/apache/arrow/pull/12014#discussion_r794749664



##########
File path: cpp/src/arrow/array/array_test.cc
##########
@@ -534,7 +534,7 @@ static ScalarVector GetScalars() {
       std::make_shared<UInt64Scalar>(3),
       std::make_shared<DoubleScalar>(3.0),
       std::make_shared<Date32Scalar>(10),
-      std::make_shared<Date64Scalar>(11),
+      std::make_shared<Date64Scalar>(864000000),

Review comment:
       Is this literal meant to be an invalid value?
   There is an extra 0 compared to `1000 x 60 x 60 x 24`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org