[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

["Paul Rogers (Code Review)" <ge...@cloudera.org>]

Hello Bharath Vissapragada, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12033

to look at the new patch set (#2).

Change subject: IMPALA-7927: Enhance Rewritten SQL in test files
......................................................................

IMPALA-7927: Enhance Rewritten SQL in test files

Makes two changes to the rewritten SQL shown in .test files:

1. Show the rewritten HAVING clause. (We have two copies. Before, the
   rewritten SQL displayed the unrewritten copy.)

2. Smap substitution replaces expressions with references to
   materialized slots. This replacement was hidden in the rewritten SQL.
   This change makes the replacement explicit.

Example of HAVING with the above changes:

HAVING $ao$1 /* sum(2 + id) */ > CAST(1 AS BIGINT)

The $ao$1 is the reference to the Aggregation Output slot 1. The column
label (an expression here) is shown in a quote for reference.

More detail in the JIRA ticket.

Testing: Affects only .test files. Reran all FE tests and updated .test
files as needed.

Change-Id: I09ee971a7797c4154bafee5c080ac3c6a1057fc7
---
M fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/main/java/org/apache/impala/analysis/SlotRef.java
M testdata/workloads/functional-planner/queries/PlannerTest/constant-folding.test
M testdata/workloads/functional-planner/queries/PlannerTest/max-row-size.test
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
M testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test
8 files changed, 66 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/12033/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09ee971a7797c4154bafee5c080ac3c6a1057fc7
Gerrit-Change-Number: 12033
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>