[jira] [Commented] (FLINK-4686) Add possibility to get column names

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525556#comment-15525556 ] 

ASF GitHub Bot commented on FLINK-4686:
---------------------------------------

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/2553

    [FLINK-4686] [table] Add possibility to get column names

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    This PR introduces `Schema` to allow us get column names and types.
    
    ```java
    Schema s = table.schema();
    TypeInformation<?> type = s.getType(1);
    TypeInformation<?> type = s.getType("col");
    String s = s.getColumnName(1);
    String[] s = s.getColumnNames();
    ```


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink schema-FLINK-4686

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2553
    
----
commit 9b40f85e9ebbe2524b440d6abc9722380467266c
Author: Jark Wu <wu...@alibaba-inc.com>
Date:   2016-09-27T09:05:27Z

    [FLINK-4686] [table] Add possibility to get column names

----


> Add possibility to get column names
> -----------------------------------
>
>                 Key: FLINK-4686
>                 URL: https://issues.apache.org/jira/browse/FLINK-4686
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Jark Wu
>              Labels: starter
>
> For debugging and maybe for visualization in future (e.g. in a shell) it would be good to have the possibilty to get the names of {{Table}} columns. At the moment the user has no idea how the table columns are named; if they need to be matched with POJO fields for example.
> My suggestion:
> {code}
> Schema s = table.schema();
> TypeInformation<?> type = s.getType(1);
> TypeInformation<?> type = s.getType("col");
> String s = s.getColumnName(1);
> String[] s = s.getColumnNames();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)