You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Barna Zsombor Klara <zs...@cloudera.com> on 2017/03/10 10:36:12 UTC

Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/
-----------------------------------------------------------

Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.


Repository: hive-git


Description
-------

HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode


Diffs
-----

  common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a479deb7c0c6b779277f1029009b7dfab6dcb9e3 
  common/src/test/org/apache/hadoop/hive/common/TestFixedSizeCollection.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 6805c17a116f5ef0febd36c59d454fa631ae0024 
  ql/src/test/queries/clientnegative/msck_repair_4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/msck_repair_0.q ce8ef426a2a58845afc8333259d66725db416584 
  ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/msck_repair_0.q.out 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba 


Diff: https://reviews.apache.org/r/57503/diff/1/


Testing
-------

Tested locally and added qtests/unit tests.


Thanks,

Barna Zsombor Klara


Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

Posted by Vihang Karajgaonkar <vi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review168642
-----------------------------------------------------------


Ship it!




Thanks for the changes Zsombor. LGTM

- Vihang Karajgaonkar


On March 10, 2017, 10:36 a.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57503/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 10:36 a.m.)
> 
> 
> Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a479deb7c0c6b779277f1029009b7dfab6dcb9e3 
>   common/src/test/org/apache/hadoop/hive/common/TestFixedSizeCollection.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 6805c17a116f5ef0febd36c59d454fa631ae0024 
>   ql/src/test/queries/clientnegative/msck_repair_4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/msck_repair_0.q ce8ef426a2a58845afc8333259d66725db416584 
>   ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/msck_repair_0.q.out 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba 
> 
> 
> Diff: https://reviews.apache.org/r/57503/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally and added qtests/unit tests.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

Posted by Barna Zsombor Klara <zs...@cloudera.com>.

> On March 15, 2017, 4:05 a.m., Naveen Gangam wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> > Line 781 (original), 781 (patched)
> > <https://reviews.apache.org/r/57503/diff/1/?file=1661200#file1661200line781>
> >
> >     We already a few config properties around the max batch sizes for tables/partitions. Would it make sense to re-use one of them? They are for the same purpose, whether it be for read or write.
> >     
> >     METASTORE_BATCH_RETRIEVE_TABLE_PARTITION_MAX
> >     METASTORE_DIRECT_SQL_PARTITION_BATCH_SIZE
> >     HIVE_MSCK_REPAIR_BATCH_SIZE
> >     METASTORE_BATCH_RETRIEVE_MAX

Those settings are a bit too low for this purpose. Here we want to limit the number of check results (lists of a pair of 2 strings) so the value should be a lot higher than the max number of partition objects.


- Barna Zsombor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review168969
-----------------------------------------------------------


On March 10, 2017, 10:36 a.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57503/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 10:36 a.m.)
> 
> 
> Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a479deb7c0c6b779277f1029009b7dfab6dcb9e3 
>   common/src/test/org/apache/hadoop/hive/common/TestFixedSizeCollection.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 6805c17a116f5ef0febd36c59d454fa631ae0024 
>   ql/src/test/queries/clientnegative/msck_repair_4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/msck_repair_0.q ce8ef426a2a58845afc8333259d66725db416584 
>   ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/msck_repair_0.q.out 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba 
> 
> 
> Diff: https://reviews.apache.org/r/57503/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally and added qtests/unit tests.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

Posted by Barna Zsombor Klara <zs...@cloudera.com>.

> On March 15, 2017, 4:05 a.m., Naveen Gangam wrote:
> > common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java
> > Lines 32 (patched)
> > <https://reviews.apache.org/r/57503/diff/1/?file=1661199#file1661199line32>
> >
> >     Since we already use common-collections library in hive, would using something like FixedSizeList or something else address the same purpose instead of having to add a new class?

Let's wait and see how we decide on the need for this fixed size collection. If we are happy with using just the PartitionIterable, then these collections are not needed anymore.


- Barna Zsombor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review168969
-----------------------------------------------------------


On March 10, 2017, 10:36 a.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57503/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 10:36 a.m.)
> 
> 
> Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a479deb7c0c6b779277f1029009b7dfab6dcb9e3 
>   common/src/test/org/apache/hadoop/hive/common/TestFixedSizeCollection.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 6805c17a116f5ef0febd36c59d454fa631ae0024 
>   ql/src/test/queries/clientnegative/msck_repair_4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/msck_repair_0.q ce8ef426a2a58845afc8333259d66725db416584 
>   ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/msck_repair_0.q.out 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba 
> 
> 
> Diff: https://reviews.apache.org/r/57503/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally and added qtests/unit tests.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

Posted by Naveen Gangam <ng...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review168969
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java
Lines 32 (patched)
<https://reviews.apache.org/r/57503/#comment241309>

    Since we already use common-collections library in hive, would using something like FixedSizeList or something else address the same purpose instead of having to add a new class?



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Line 781 (original), 781 (patched)
<https://reviews.apache.org/r/57503/#comment241308>

    We already a few config properties around the max batch sizes for tables/partitions. Would it make sense to re-use one of them? They are for the same purpose, whether it be for read or write.
    
    METASTORE_BATCH_RETRIEVE_TABLE_PARTITION_MAX
    METASTORE_DIRECT_SQL_PARTITION_BATCH_SIZE
    HIVE_MSCK_REPAIR_BATCH_SIZE
    METASTORE_BATCH_RETRIEVE_MAX


- Naveen Gangam


On March 10, 2017, 10:36 a.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57503/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 10:36 a.m.)
> 
> 
> Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a479deb7c0c6b779277f1029009b7dfab6dcb9e3 
>   common/src/test/org/apache/hadoop/hive/common/TestFixedSizeCollection.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 6805c17a116f5ef0febd36c59d454fa631ae0024 
>   ql/src/test/queries/clientnegative/msck_repair_4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/msck_repair_0.q ce8ef426a2a58845afc8333259d66725db416584 
>   ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/msck_repair_0.q.out 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba 
> 
> 
> Diff: https://reviews.apache.org/r/57503/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally and added qtests/unit tests.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

Posted by Barna Zsombor Klara <zs...@cloudera.com>.

> On March 14, 2017, 9:35 p.m., Sergio Pena wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java
> > Line 219 (original), 223-228 (patched)
> > <https://reviews.apache.org/r/57503/diff/1/?file=1661202#file1661202line225>
> >
> >     Does this mean that if a user attempts to repair a table with more than 500_000 partitions, the MSCK will fail?
> >     
> >     If so, I think we're having the same problem as before. Users won't be able to discover all partitions from a table with more than 500_000.
> >     
> >     Did we have problems before the patch which added this regression issue? If not, should we use PartitionIterable with unlimited number of partitions instead? The number of HMS transactions due to PartitionIterable shouldn't be a problem if the user increases the batch size. Also, as Vihang mentioned, we're just storing two values (partition name + table name), so that consumes less memory than using the hive.getPartition() method call.

This would limit the number of results the metastore check can return, so it would fail if there are over 500_000 partitions not on the FS or in the MS.I added this check because you expressed concerns in the Jira about an OOM situation when there are million of partitions (fetched in batches), and none of the partitions exist on the filesystem. If you changed your mind and you think that this is not a great concern (because as Vihang pointed out these are only string pairs) then we should go with the previous version of my patch.


- Barna Zsombor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review168942
-----------------------------------------------------------


On March 10, 2017, 10:36 a.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57503/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 10:36 a.m.)
> 
> 
> Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a479deb7c0c6b779277f1029009b7dfab6dcb9e3 
>   common/src/test/org/apache/hadoop/hive/common/TestFixedSizeCollection.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 6805c17a116f5ef0febd36c59d454fa631ae0024 
>   ql/src/test/queries/clientnegative/msck_repair_4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/msck_repair_0.q ce8ef426a2a58845afc8333259d66725db416584 
>   ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/msck_repair_0.q.out 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba 
> 
> 
> Diff: https://reviews.apache.org/r/57503/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally and added qtests/unit tests.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review168942
-----------------------------------------------------------




common/src/test/org/apache/hadoop/hive/common/TestFixedSizeCollection.java
Lines 32 (patched)
<https://reviews.apache.org/r/57503/#comment241253>

    Should we use the java naming convention for method names?



ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java
Line 219 (original), 223-228 (patched)
<https://reviews.apache.org/r/57503/#comment241252>

    Does this mean that if a user attempts to repair a table with more than 500_000 partitions, the MSCK will fail?
    
    If so, I think we're having the same problem as before. Users won't be able to discover all partitions from a table with more than 500_000.
    
    Did we have problems before the patch which added this regression issue? If not, should we use PartitionIterable with unlimited number of partitions instead? The number of HMS transactions due to PartitionIterable shouldn't be a problem if the user increases the batch size. Also, as Vihang mentioned, we're just storing two values (partition name + table name), so that consumes less memory than using the hive.getPartition() method call.


- Sergio Pena


On March 10, 2017, 10:36 a.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57503/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 10:36 a.m.)
> 
> 
> Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a479deb7c0c6b779277f1029009b7dfab6dcb9e3 
>   common/src/test/org/apache/hadoop/hive/common/TestFixedSizeCollection.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 6805c17a116f5ef0febd36c59d454fa631ae0024 
>   ql/src/test/queries/clientnegative/msck_repair_4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/msck_repair_0.q ce8ef426a2a58845afc8333259d66725db416584 
>   ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/msck_repair_0.q.out 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba 
> 
> 
> Diff: https://reviews.apache.org/r/57503/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally and added qtests/unit tests.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/
-----------------------------------------------------------

(Updated March 20, 2017, 9:03 a.m.)


Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.


Changes
-------

Updated qtest to find/repair partitions in strict mode.


Bugs: HIVE-16024
    https://issues.apache.org/jira/browse/HIVE-16024


Repository: hive-git


Description
-------

HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 6805c17a116f5ef0febd36c59d454fa631ae0024 
  ql/src/test/queries/clientpositive/msck_repair_0.q ce8ef426a2a58845afc8333259d66725db416584 
  ql/src/test/results/clientpositive/msck_repair_0.q.out 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba 


Diff: https://reviews.apache.org/r/57503/diff/3/

Changes: https://reviews.apache.org/r/57503/diff/2-3/


Testing
-------

Tested locally and added qtests/unit tests.


Thanks,

Barna Zsombor Klara


Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

Posted by Barna Zsombor Klara <zs...@cloudera.com>.

> On March 17, 2017, 8:30 p.m., Sergio Pena wrote:
> > ql/src/test/queries/clientpositive/msck_repair_0.q
> > Lines 19-21 (patched)
> > <https://reviews.apache.org/r/57503/diff/2/?file=1666109#file1666109line19>
> >
> >     Is this actually adding new partitios to the metastore? Those are already discovered above. I think this part is not testing the changes correctly.

The check was initially failing in strict mode even if there were no partitions to be discovered/repaired, but I can change the test to find new partitions missing from the HMS.


- Barna Zsombor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review169324
-----------------------------------------------------------


On March 16, 2017, 3:55 p.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57503/
> -----------------------------------------------------------
> 
> (Updated March 16, 2017, 3:55 p.m.)
> 
> 
> Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 6805c17a116f5ef0febd36c59d454fa631ae0024 
>   ql/src/test/queries/clientpositive/msck_repair_0.q ce8ef426a2a58845afc8333259d66725db416584 
>   ql/src/test/results/clientpositive/msck_repair_0.q.out 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba 
> 
> 
> Diff: https://reviews.apache.org/r/57503/diff/2/
> 
> 
> Testing
> -------
> 
> Tested locally and added qtests/unit tests.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/#review169324
-----------------------------------------------------------




ql/src/test/queries/clientpositive/msck_repair_0.q
Lines 19-21 (patched)
<https://reviews.apache.org/r/57503/#comment241669>

    Is this actually adding new partitios to the metastore? Those are already discovered above. I think this part is not testing the changes correctly.


- Sergio Pena


On March 16, 2017, 3:55 p.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57503/
> -----------------------------------------------------------
> 
> (Updated March 16, 2017, 3:55 p.m.)
> 
> 
> Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 6805c17a116f5ef0febd36c59d454fa631ae0024 
>   ql/src/test/queries/clientpositive/msck_repair_0.q ce8ef426a2a58845afc8333259d66725db416584 
>   ql/src/test/results/clientpositive/msck_repair_0.q.out 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba 
> 
> 
> Diff: https://reviews.apache.org/r/57503/diff/2/
> 
> 
> Testing
> -------
> 
> Tested locally and added qtests/unit tests.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57503/
-----------------------------------------------------------

(Updated March 16, 2017, 3:55 p.m.)


Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.


Changes
-------

Updated the patch after discussing with Sergio.


Repository: hive-git


Description
-------

HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 6805c17a116f5ef0febd36c59d454fa631ae0024 
  ql/src/test/queries/clientpositive/msck_repair_0.q ce8ef426a2a58845afc8333259d66725db416584 
  ql/src/test/results/clientpositive/msck_repair_0.q.out 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba 


Diff: https://reviews.apache.org/r/57503/diff/2/

Changes: https://reviews.apache.org/r/57503/diff/1-2/


Testing
-------

Tested locally and added qtests/unit tests.


Thanks,

Barna Zsombor Klara